From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40830 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ptg28-0002vN-Hp for qemu-devel@nongnu.org; Sun, 27 Feb 2011 07:47:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ptg1R-0008VU-Rm for qemu-devel@nongnu.org; Sun, 27 Feb 2011 07:46:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25817) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ptg1R-0008VG-5I for qemu-devel@nongnu.org; Sun, 27 Feb 2011 07:46:49 -0500 Message-ID: <4D6A47B5.2070901@redhat.com> Date: Sun, 27 Feb 2011 14:46:45 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1298584085-13129-1-git-send-email-aliguori@us.ibm.com> <1298584085-13129-3-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1298584085-13129-3-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/3] kvm-unit-tests: do not set level sensitive irq when initializing the PIC List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org On 02/24/2011 11:48 PM, Anthony Liguori wrote: > I'm not sure if this was intentional but the QEMU i8259 does not support this > flag. I haven't observed any issues with this but I'll happily admit that > I'm not very aware of what I'm doing here. > > Signed-off-by: Anthony Liguori > > static u32 xapic_read(unsigned reg) > { > return *(volatile u32 *)(g_apic + reg); > @@ -133,7 +129,7 @@ void ioapic_write_redir(unsigned line, ioapic_redir_entry_t e) > void enable_apic(void) > { > printf("enabling apic\n"); > - xapic_write(0xf0, 0x1ff); /* spurious vector register */ > + xapic_write(0xf0, 0x1f7); /* spurious vector register */ > } Not sure what you're doing here. You're changing the APIC Spurious Vector from 0xff to 0xf7? This has nothing to do with the i8259 or level triggeredness as far as I can tell - it just enables the APIC (bit 8) and selects a vector for reporting spurious interrupts (0xff happens to be the reset value). -- error compiling committee.c: too many arguments to function