qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: qemu-devel@nongnu.org, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH 3/3] kvm-unit-tests: make I/O more friendly to existing QEMU hardware
Date: Sun, 27 Feb 2011 14:49:18 +0200	[thread overview]
Message-ID: <4D6A484E.3040306@redhat.com> (raw)
In-Reply-To: <1298584085-13129-4-git-send-email-aliguori@us.ibm.com>

On 02/24/2011 11:48 PM, Anthony Liguori wrote:
> Use the serial port for printf() and use the Bochs bios exit port if the
> testdev port isn't available.
>
> This unconditionally switches to use the serial port but tries to use the
> testdev exit port since that lets you pass an exit status.

The only issue I can see is that the serial port is much slower than the 
testdev port (since we can use rep outsb there).  That only matters for 
access.flat in full output mode (not default).  So please keep the old 
code under #if 0 so we can easily switch back to it.

-- 
error compiling committee.c: too many arguments to function

      reply	other threads:[~2011-02-27 12:49 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-24 21:48 [Qemu-devel] [RFC PATCH 0/3] Make kvm-unit-tests more friendly to upstream QEMU Anthony Liguori
2011-02-24 21:48 ` [Qemu-devel] [PATCH 1/3] kvm-unit-tests: add x86 port io accessors Anthony Liguori
2011-02-27 12:44   ` [Qemu-devel] " Avi Kivity
2011-02-27 14:01     ` Anthony Liguori
2011-02-27 15:32       ` Avi Kivity
2011-02-24 21:48 ` [Qemu-devel] [PATCH 2/3] kvm-unit-tests: do not set level sensitive irq when initializing the PIC Anthony Liguori
2011-02-27 12:46   ` [Qemu-devel] " Avi Kivity
2011-02-24 21:48 ` [Qemu-devel] [PATCH 3/3] kvm-unit-tests: make I/O more friendly to existing QEMU hardware Anthony Liguori
2011-02-27 12:49   ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D6A484E.3040306@redhat.com \
    --to=avi@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).