From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=32771 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PtiE3-00026C-BF
	for qemu-devel@nongnu.org; Sun, 27 Feb 2011 10:08:00 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PtiE1-00027x-Oo
	for qemu-devel@nongnu.org; Sun, 27 Feb 2011 10:07:59 -0500
Received: from mail-wy0-f173.google.com ([74.125.82.173]:61121)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PtiE1-00027h-Kn
	for qemu-devel@nongnu.org; Sun, 27 Feb 2011 10:07:57 -0500
Received: by wyb29 with SMTP id 29so3141299wyb.4
	for <qemu-devel@nongnu.org>; Sun, 27 Feb 2011 07:07:56 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4D6A68CA.7030602@redhat.com>
Date: Sun, 27 Feb 2011 16:07:54 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1298734819-1960-1-git-send-email-pbonzini@redhat.com>	<1298734819-1960-20-git-send-email-pbonzini@redhat.com>
	<4D6A1C58.4050605@web.de>
In-Reply-To: <4D6A1C58.4050605@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 upstream 19/22] move blocking of signals
	to qemu_signalfd_init
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>

On 02/27/2011 10:41 AM, Jan Kiszka wrote:
>> >  +#ifdef CONFIG_IOTHREAD
>> >  +    /* SIGUSR2 used by posix-aio-compat.c */
>> >  +    sigemptyset(&set);
>> >  +    sigaddset(&set, SIGUSR2);
>> >  +    pthread_sigmask(SIG_UNBLOCK,&set, NULL);
>
> Didn't you want to rename the function for the sake of non-signalfd
> blocks like above?

Right.

>> >  +
>> >  +    sigemptyset(&set);
>> >  +    sigaddset(&set, SIGIO);
>> >  +    sigaddset(&set, SIGALRM);
>> >  +    sigaddset(&set, SIG_IPI);
>> >  +    sigaddset(&set, SIGBUS);
>> >  +    pthread_sigmask(SIG_BLOCK,&set, NULL);
>> >  +#else
>> >  +    sigemptyset(&set);
>
> This line is shared and can be moved out of the #ifdef.

It's shared but for different purposes (UNBLOCK for iothread, 
BLOCK/signalfd for !iothread), so I decided not to hoist it out.

Paolo