From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=59372 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PtmH0-00038a-7w for qemu-devel@nongnu.org; Sun, 27 Feb 2011 14:27:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PtmGu-0001as-UD for qemu-devel@nongnu.org; Sun, 27 Feb 2011 14:27:18 -0500 Received: from fmmailgate02.web.de ([217.72.192.227]:60661) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PtmGu-0001aP-Eu for qemu-devel@nongnu.org; Sun, 27 Feb 2011 14:27:12 -0500 Message-ID: <4D6AA585.4020204@web.de> Date: Sun, 27 Feb 2011 20:27:01 +0100 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: kvm crashes with spice while loading qxl References: <4D68F20D.2020401@web.de> <20110227190312.GA14445@playa.redhat.com> <4D6AA1DE.6020102@web.de> <20110227191608.GB14445@playa.redhat.com> In-Reply-To: <20110227191608.GB14445@playa.redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig19B90B31B0521FFC201127BC" Sender: jan.kiszka@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: xming , Gerd Hoffmann , kvm@vger.kernel.org, qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig19B90B31B0521FFC201127BC Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-02-27 20:16, Alon Levy wrote: > On Sun, Feb 27, 2011 at 08:11:26PM +0100, Jan Kiszka wrote: >> On 2011-02-27 20:03, Alon Levy wrote: >>> On Sat, Feb 26, 2011 at 01:29:01PM +0100, Jan Kiszka wrote: >>>> On 2011-02-26 12:43, xming wrote: >>>>> When trying to start X (and it loads qxl driver) the kvm process ju= st crashes. >>> >>> This is fixed by Gerd's attached patch (taken from rhel repository, d= on't know >>> why it wasn't pushed to qemu-kvm upstream). I'll send it to kvm list = as well (separate email). >> >> Patch looks OK on first glance, but the changelog is misleading: This >> was broken for _both_ trees, but upstream didn't detect the bug. >> >=20 > The trees the patch commit message refers to are qemu and qemu-kvm. The same did I. > qemu doesn't even have cpu_single_env. Really? Check again. :) > It didn't talk about two qemu-kvm trees. >=20 >> My concerns regarding other side effects of juggling with global mutex= >> in spice code remain. >=20 > I know there used to be a mutex in spice code and during the upstreamin= g process it > got ditched in favor of the qemu global io mutex. I would have rather d= eferred this > to Gerd since he wrote this, but he is not available atm. It's not necessarily bad to drop the io mutex, but it is more tricky than it may appear on first glance. Jan --------------enig19B90B31B0521FFC201127BC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk1qpYUACgkQitSsb3rl5xSJ2ACfUJJUvJ9NKnfedO7o7Q4UxZLG 0zYAnivhEkS0lDwIJnIjaLICseGuuS3q =V2Y4 -----END PGP SIGNATURE----- --------------enig19B90B31B0521FFC201127BC--