From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37770 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pu1yi-0006GF-0c for qemu-devel@nongnu.org; Mon, 28 Feb 2011 07:13:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pu1ya-0001Cm-DR for qemu-devel@nongnu.org; Mon, 28 Feb 2011 07:13:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:45168) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pu1ya-0001Cd-4S for qemu-devel@nongnu.org; Mon, 28 Feb 2011 07:13:20 -0500 Message-ID: <4D6B9154.6000601@redhat.com> Date: Mon, 28 Feb 2011 14:13:08 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1298884224-19734-1-git-send-email-pbonzini@redhat.com> <4D6B67E0.4040408@redhat.com> <4D6B7479.5010307@redhat.com> <4D6B8D92.8050807@siemens.com> In-Reply-To: <4D6B8D92.8050807@siemens.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v3 uq/master 00/22] Win32 iothread support List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: kvm@vger.kernel.org, mtosatti@redhat.com, qemu-devel@nongnu.org, blauwirbel@gmail.com, Paolo Bonzini , aurelien@aurel32.net On 02/28/2011 01:57 PM, Jan Kiszka wrote: > On 2011-02-28 11:10, Paolo Bonzini wrote: > > On 02/28/2011 10:16 AM, Avi Kivity wrote: > >> Why is that? uq/master is for kvm code, and this touches two or three > >> lines? > > > > iothread code is also going in via uq/master often. I started with > > uq/master because I depended on Jan's changes which are now upstream, I > > have no problems with this going directly to qemu.git. > > As this touches the iothread, a central subsystem full of kvm code, and > as uq/master is known to be checked against autotest, I still think > uq/master is the right choice. > If there's a git tree of this I'll be happy to do an autotest run. -- error compiling committee.c: too many arguments to function