From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48274 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PuEms-0004Vf-KT for qemu-devel@nongnu.org; Mon, 28 Feb 2011 20:54:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PuEhL-0008UG-2H for qemu-devel@nongnu.org; Mon, 28 Feb 2011 20:48:24 -0500 Received: from e8.ny.us.ibm.com ([32.97.182.138]:42019) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PuEhK-0008UA-Ql for qemu-devel@nongnu.org; Mon, 28 Feb 2011 20:48:23 -0500 Received: from d01dlp01.pok.ibm.com (d01dlp01.pok.ibm.com [9.56.224.56]) by e8.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p1SLTYYV026911 for ; Mon, 28 Feb 2011 16:29:34 -0500 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id AA16A38C8038 for ; Mon, 28 Feb 2011 20:48:15 -0500 (EST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p211mGJR448036 for ; Mon, 28 Feb 2011 20:48:16 -0500 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p211mFTh016452 for ; Mon, 28 Feb 2011 18:48:15 -0700 Message-ID: <4D6C5072.9030301@linux.vnet.ibm.com> Date: Mon, 28 Feb 2011 17:48:34 -0800 From: "Venkateswararao Jujjuri (JV)" MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RFC PATCH -V1 3/4] hw/9pfs: Implement syncfs References: <1296929291-11047-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1296929291-11047-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: <1296929291-11047-3-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Aneesh Kumar K.V" Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On 2/5/2011 10:08 AM, Aneesh Kumar K.V wrote: > Signed-off-by: Aneesh Kumar K.V > --- > hw/9pfs/virtio-9p.c | 31 +++++++++++++++++++++++++++++++ > hw/9pfs/virtio-9p.h | 2 ++ > 2 files changed, 33 insertions(+), 0 deletions(-) > > diff --git a/hw/9pfs/virtio-9p.c b/hw/9pfs/virtio-9p.c > index 2d9ca11..1518e00 100644 > --- a/hw/9pfs/virtio-9p.c > +++ b/hw/9pfs/virtio-9p.c > @@ -1978,6 +1978,36 @@ static void v9fs_fsync(V9fsState *s, V9fsPDU *pdu) > v9fs_post_do_fsync(s, pdu, err); > } > > +static void v9fs_post_do_syncfs(V9fsState *s, V9fsPDU *pdu, int err) > +{ > + if (err == -1) { > + err = -errno; > + } > + complete_pdu(s, pdu, err); > +} > + > +static void v9fs_syncfs(V9fsState *s, V9fsPDU *pdu) > +{ > + int err; > + int32_t fid; > + size_t offset = 7; > + V9fsFidState *fidp; > + > + pdu_unmarshal(pdu, offset, "d", &fid); > + fidp = lookup_fid(s, fid); > + if (fidp == NULL) { > + err = -ENOENT; > + v9fs_post_do_syncfs(s, pdu, err); > + return; > + } > + /* > + * We don't have per file system syncfs > + * So just return success > + */ > + err = 0; How about err = 0 if (fidp == NULL) err = -ENOENT > + v9fs_post_do_syncfs(s, pdu, err); > +} > + > static void v9fs_clunk(V9fsState *s, V9fsPDU *pdu) > { > int32_t fid; > @@ -3676,6 +3706,7 @@ static pdu_handler_t *pdu_handlers[] = { > [P9_TWALK] = v9fs_walk, > [P9_TCLUNK] = v9fs_clunk, > [P9_TFSYNC] = v9fs_fsync, > + [P9_TSYNCFS] = v9fs_syncfs, > [P9_TOPEN] = v9fs_open, > [P9_TREAD] = v9fs_read, > #if 0 > diff --git a/hw/9pfs/virtio-9p.h b/hw/9pfs/virtio-9p.h > index 82b4252..b2cd24b 100644 > --- a/hw/9pfs/virtio-9p.h > +++ b/hw/9pfs/virtio-9p.h > @@ -13,6 +13,8 @@ > #define VIRTIO_9P_MOUNT_TAG 0 > > enum { > + P9_TSYNCFS = 0, > + P9_RSYNCFS, > P9_TLERROR = 6, > P9_RLERROR, > P9_TSTATFS = 8,