From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=38701 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PuL7k-0006d2-CS for qemu-devel@nongnu.org; Tue, 01 Mar 2011 03:40:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PuL7j-00063t-4m for qemu-devel@nongnu.org; Tue, 01 Mar 2011 03:40:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53099) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PuL7i-00063n-Nx for qemu-devel@nongnu.org; Tue, 01 Mar 2011 03:40:03 -0500 Message-ID: <4D6CB0DD.5030505@redhat.com> Date: Tue, 01 Mar 2011 10:39:57 +0200 From: Avi Kivity MIME-Version: 1.0 References: <688de146287dc589a2e0fcce4cdec85d4f2c1127.1296594961.git.jan.kiszka@web.de> <4D6BC55B.9030805@redhat.com> <4D6BCA6A.9060507@siemens.com> <4D6BD144.5050406@redhat.com> <4D6BD220.6010606@siemens.com> <4D6BD33D.8050405@redhat.com> In-Reply-To: <4D6BD33D.8050405@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v2 13/24] kvm: Set up signal mask also for !CONFIG_IOTHREAD List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Marcelo Tosatti , "qemu-devel@nongnu.org" , "kvm@vger.kernel.org" On 02/28/2011 06:54 PM, Avi Kivity wrote: > On 02/28/2011 06:49 PM, Jan Kiszka wrote: >> > >> > That's what I tried, and it didn't work?! Maybe I forgot to >> compile or >> > something. >> >> Well, it maybe failed to build as qemu_kvm_init_cpu_signals became >> unused and the compiler should have bailed out? Probably it's better to >> disable it directly in the function. >> > > That's what I did, with #ifdefs, but brokenly (#ifndef). > > Well it fails even with the correct #ifdef. Maybe some later patch adds to the breakage. This is really strange - the same test (migrate.tcp) works for Fedora and Windows XP x86. Installation and setup of Windows XP x64 work fine. It is only migration.tcp (when using netcat to connect to the guest) that fails. -- error compiling committee.c: too many arguments to function