From: Kevin Wolf <kwolf@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel <qemu-devel@nongnu.org>,
Ananth Narayan <ananth@linux.vnet.ibm.com>,
Christoph Hellwig <hch@lst.de>,
Prerna Saxena <prerna@linux.vnet.ibm.com>,
Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [RFC][PATCH 0/2] Allow cache settings for block devices to be changed at runtime.
Date: Wed, 02 Mar 2011 08:57:26 +0100 [thread overview]
Message-ID: <4D6DF866.4060804@redhat.com> (raw)
In-Reply-To: <4D6D4569.8070502@codemonkey.ws>
Am 01.03.2011 20:13, schrieb Anthony Liguori:
> On 03/01/2011 07:50 AM, Christoph Hellwig wrote:
>> On Tue, Mar 01, 2011 at 12:48:34PM +0000, Stefan Hajnoczi wrote:
>>
>>> On Tue, Mar 01, 2011 at 01:42:54PM +0100, Christoph Hellwig wrote:
>>>
>>>> I have patches to do that, and to allow changing O_DIRECT via a monitor
>>>> command, but to toggle O_SYNC via fcntl I first need to get a kernel
>>>> patch in as that's currently not allowed to be changed at runtime.
>>>>
>>> Great it sounds like you have already implemented the two cases (guest wce and
>>> host O_DIRECT) that we're talking about.
>>>
>> At least in theory. And for Linux I can add setting/clearing of O_SYNC
>> via fcntl easily, but what do we do for other hosts?
>
> To start with, we can just fail the command at the QMP level.
O_SYNC isn't toggled from QMP but from the guest.
Kevin
next prev parent reply other threads:[~2011-03-02 7:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 11:49 [Qemu-devel] [RFC][PATCH 0/2] Allow cache settings for block devices to be changed at runtime Prerna Saxena
2011-02-28 12:07 ` [Qemu-devel] [RFC][PATCH 1/2] Add monitor command 'set-cache' to change cache settings for a block device Prerna Saxena
2011-02-28 12:11 ` [Qemu-devel] [RFC][PATCH 2/2] Extend monitor command 'info block' to display cache settings for block devices Prerna Saxena
2011-02-28 15:15 ` Kevin Wolf
2011-02-28 15:12 ` [Qemu-devel] [RFC][PATCH 0/2] Allow cache settings for block devices to be changed at runtime Kevin Wolf
2011-02-28 15:35 ` Stefan Hajnoczi
2011-02-28 15:48 ` Kevin Wolf
2011-03-01 9:55 ` Stefan Hajnoczi
2011-03-01 10:06 ` Kevin Wolf
2011-03-01 15:02 ` Chunqiang Tang
2011-03-01 13:03 ` Anthony Liguori
2011-03-01 13:22 ` Kevin Wolf
2011-03-01 15:47 ` Anthony Liguori
2011-03-01 12:42 ` Christoph Hellwig
2011-03-01 12:48 ` Stefan Hajnoczi
2011-03-01 12:50 ` Christoph Hellwig
2011-03-01 19:13 ` Anthony Liguori
2011-03-02 7:57 ` Kevin Wolf [this message]
2011-03-01 12:52 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6DF866.4060804@redhat.com \
--to=kwolf@redhat.com \
--cc=ananth@linux.vnet.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=hch@lst.de \
--cc=prerna@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).