qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Juan Quintela" <quintela@redhat.com>,
	patches@linaro.org, "Dawid Ciężarkiewicz" <dawidc@b-labs.com>,
	"Amit Mahajan" <amit.mahajan@b-labs.com>,
	qemu-devel@nongnu.org, "Bahadir Balban" <bbalban@b-labs.com>
Subject: [Qemu-devel] Re: [PATCH v2 1/2] hw/arm_sysctl.c: Add the Versatile Express system registers
Date: Sat, 05 Mar 2011 13:11:44 +0100	[thread overview]
Message-ID: <4D722880.6090103@redhat.com> (raw)
In-Reply-To: <1299270860-8927-2-git-send-email-peter.maydell@linaro.org>

On 03/04/2011 09:34 PM, Peter Maydell wrote:
>       .name = "realview_sysctl",
> -    .version_id = 1,
> -    .minimum_version_id = 1,
> +    .version_id = 2,
> +    .minimum_version_id = 2,
>       .fields = (VMStateField[]) {
>           VMSTATE_UINT32(leds, arm_sysctl_state),
>           VMSTATE_UINT16(lockval, arm_sysctl_state),
> @@ -41,6 +44,9 @@ static const VMStateDescription vmstate_arm_sysctl = {
>           VMSTATE_UINT32(flags, arm_sysctl_state),
>           VMSTATE_UINT32(nvflags, arm_sysctl_state),
>           VMSTATE_UINT32(resetlevel, arm_sysctl_state),
> +        VMSTATE_UINT32(sys_cfgdata, arm_sysctl_state),
> +        VMSTATE_UINT32(sys_cfgctrl, arm_sysctl_state),
> +        VMSTATE_UINT32(sys_cfgstat, arm_sysctl_state),
>           VMSTATE_END_OF_LIST()
>       }

You need to present the fields as version 2-only.

Paolo

  reply	other threads:[~2011-03-05 12:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-04 20:34 [Qemu-devel] [PATCH v2 0/2] ARM: Add Versatile Express board model Peter Maydell
2011-03-04 20:34 ` [Qemu-devel] [PATCH v2 1/2] hw/arm_sysctl.c: Add the Versatile Express system registers Peter Maydell
2011-03-05 12:11   ` Paolo Bonzini [this message]
2011-03-05 12:34     ` [Qemu-devel] " Peter Maydell
2011-03-05 14:59       ` Paolo Bonzini
2011-03-05 16:50         ` Peter Maydell
2011-03-05 17:04           ` Paolo Bonzini
2011-03-07 11:45             ` Peter Maydell
2011-03-07 12:09               ` Jan Kiszka
2011-03-22 19:05           ` Peter Maydell
2011-03-22 19:53           ` Juan Quintela
2011-03-22 20:32             ` Peter Maydell
2011-03-23  8:54               ` Paolo Bonzini
2011-03-23  9:44               ` Juan Quintela
2011-03-04 20:34 ` [Qemu-devel] [PATCH v2 2/2] hw/vexpress.c: Add model of ARM Versatile Express board Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D722880.6090103@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=amit.mahajan@b-labs.com \
    --cc=bbalban@b-labs.com \
    --cc=dawidc@b-labs.com \
    --cc=patches@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).