From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54626 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PvqKs-0000pH-64
	for qemu-devel@nongnu.org; Sat, 05 Mar 2011 07:11:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PvqKr-0004vn-2w
	for qemu-devel@nongnu.org; Sat, 05 Mar 2011 07:11:49 -0500
Received: from mail-wy0-f173.google.com ([74.125.82.173]:60766)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PvqKq-0004vi-Ur
	for qemu-devel@nongnu.org; Sat, 05 Mar 2011 07:11:49 -0500
Received: by wyb29 with SMTP id 29so3299092wyb.4
	for <qemu-devel@nongnu.org>; Sat, 05 Mar 2011 04:11:48 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4D722880.6090103@redhat.com>
Date: Sat, 05 Mar 2011 13:11:44 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1299270860-8927-1-git-send-email-peter.maydell@linaro.org>
	<1299270860-8927-2-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1299270860-8927-2-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2 1/2] hw/arm_sysctl.c: Add the Versatile
 Express system registers
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Juan Quintela <quintela@redhat.com>, patches@linaro.org, =?UTF-8?B?RGF3aWQgQ2nEmcW8YXJraWV3aWN6?= <dawidc@b-labs.com>, Amit Mahajan <amit.mahajan@b-labs.com>, qemu-devel@nongnu.org, Bahadir Balban <bbalban@b-labs.com>

On 03/04/2011 09:34 PM, Peter Maydell wrote:
>       .name = "realview_sysctl",
> -    .version_id = 1,
> -    .minimum_version_id = 1,
> +    .version_id = 2,
> +    .minimum_version_id = 2,
>       .fields = (VMStateField[]) {
>           VMSTATE_UINT32(leds, arm_sysctl_state),
>           VMSTATE_UINT16(lockval, arm_sysctl_state),
> @@ -41,6 +44,9 @@ static const VMStateDescription vmstate_arm_sysctl = {
>           VMSTATE_UINT32(flags, arm_sysctl_state),
>           VMSTATE_UINT32(nvflags, arm_sysctl_state),
>           VMSTATE_UINT32(resetlevel, arm_sysctl_state),
> +        VMSTATE_UINT32(sys_cfgdata, arm_sysctl_state),
> +        VMSTATE_UINT32(sys_cfgctrl, arm_sysctl_state),
> +        VMSTATE_UINT32(sys_cfgstat, arm_sysctl_state),
>           VMSTATE_END_OF_LIST()
>       }

You need to present the fields as version 2-only.

Paolo