From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "Juan Quintela" <quintela@redhat.com>,
patches@linaro.org, "Dawid Ciężarkiewicz" <dawidc@b-labs.com>,
"Amit Mahajan" <amit.mahajan@b-labs.com>,
qemu-devel@nongnu.org, "Bahadir Balban" <bbalban@b-labs.com>
Subject: [Qemu-devel] Re: [PATCH v2 1/2] hw/arm_sysctl.c: Add the Versatile Express system registers
Date: Sat, 05 Mar 2011 15:59:01 +0100 [thread overview]
Message-ID: <4D724FB5.1040601@redhat.com> (raw)
In-Reply-To: <AANLkTik=DHLVVCouZj_L6fZ7Y-ycPvCgD+usKj=+WU0+@mail.gmail.com>
On 03/05/2011 01:34 PM, Peter Maydell wrote:
>>> >> + VMSTATE_UINT32(sys_cfgdata, arm_sysctl_state),
>>> >> + VMSTATE_UINT32(sys_cfgctrl, arm_sysctl_state),
>>> >> + VMSTATE_UINT32(sys_cfgstat, arm_sysctl_state),
>>> >> VMSTATE_END_OF_LIST()
>>> >> }
>> >
>> > You need to present the fields as version 2-only.
> Can you give an example/explanation? docs/migration.txt doesn't
> seem to cover this...
Sure, sorry for being terse. It simply needs to be:
VMSTATE_UINT32_V(sys_cfgdata, arm_sysctl_state, 2),
VMSTATE_UINT32_V(sys_cfgctrl, arm_sysctl_state, 2),
VMSTATE_UINT32_V(sys_cfgstat, arm_sysctl_state, 2),
Also, minimum_version_id needs to remain 1 since you do support loading
version 1 saved virtual machines.
Paolo
next prev parent reply other threads:[~2011-03-05 14:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 20:34 [Qemu-devel] [PATCH v2 0/2] ARM: Add Versatile Express board model Peter Maydell
2011-03-04 20:34 ` [Qemu-devel] [PATCH v2 1/2] hw/arm_sysctl.c: Add the Versatile Express system registers Peter Maydell
2011-03-05 12:11 ` [Qemu-devel] " Paolo Bonzini
2011-03-05 12:34 ` Peter Maydell
2011-03-05 14:59 ` Paolo Bonzini [this message]
2011-03-05 16:50 ` Peter Maydell
2011-03-05 17:04 ` Paolo Bonzini
2011-03-07 11:45 ` Peter Maydell
2011-03-07 12:09 ` Jan Kiszka
2011-03-22 19:05 ` Peter Maydell
2011-03-22 19:53 ` Juan Quintela
2011-03-22 20:32 ` Peter Maydell
2011-03-23 8:54 ` Paolo Bonzini
2011-03-23 9:44 ` Juan Quintela
2011-03-04 20:34 ` [Qemu-devel] [PATCH v2 2/2] hw/vexpress.c: Add model of ARM Versatile Express board Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D724FB5.1040601@redhat.com \
--to=pbonzini@redhat.com \
--cc=amit.mahajan@b-labs.com \
--cc=bbalban@b-labs.com \
--cc=dawidc@b-labs.com \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).