From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53498 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PwFb1-00011L-7D
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 10:10:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1PwFb0-0002vg-4E
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 10:10:11 -0500
Received: from fmmailgate03.web.de ([217.72.192.234]:59504)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1PwFaz-0002vF-Uc
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 10:10:10 -0500
Message-ID: <4D73A3CC.3080901@web.de>
Date: Sun, 06 Mar 2011 16:10:04 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <AANLkTinReKqGNOHY9OWEn17JYA5ezm5dbtvZB2Ca2rs+@mail.gmail.com>
In-Reply-To: <AANLkTinReKqGNOHY9OWEn17JYA5ezm5dbtvZB2Ca2rs+@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig9EBE58E634046E9837DD4674"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH 4/4] i8254: convert to qdev
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig9EBE58E634046E9837DD4674
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 2011-02-13 22:10, Blue Swirl wrote:
> Convert to qdev. Don't expose PITState.
>=20

=2E..

> diff --git a/hw/pc.h b/hw/pc.h
> index 60f8c42..feb8a7a 100644
> --- a/hw/pc.h
> +++ b/hw/pc.h
> @@ -82,14 +82,23 @@ void isa_irq_handler(void *opaque, int n, int level=
);
>=20
>  #define PIT_FREQ 1193182
>=20
> -typedef struct PITState PITState;
> +static inline ISADevice *pit_init(int base, int irq)
> +{
> +    ISADevice *dev;
> +
> +    dev =3D isa_create("isa-pit");
> +    qdev_prop_set_uint32(&dev->qdev, "iobase", base);
> +    qdev_prop_set_uint32(&dev->qdev, "irq", irq);
> +    qdev_init_nofail(&dev->qdev);
> +
> +    return dev;
> +}

This should be moved to i8254.c. We cannot compile the PIT out, and the
above contains no board information. So I see no reason for this inlining=
=2E

Jan



--------------enig9EBE58E634046E9837DD4674
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk1zo88ACgkQitSsb3rl5xTTUwCcCGdqDnLGuMjGQyqKxWV66rUy
1xwAn0VH/A1FtHczgeXoh44Qm0XkZZqt
=mvKI
-----END PGP SIGNATURE-----

--------------enig9EBE58E634046E9837DD4674--