From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=58057 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PwG3W-00036M-1Z
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 10:39:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1PwG3V-0003De-B7
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 10:39:38 -0500
Received: from fmmailgate03.web.de ([217.72.192.234]:60790)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1PwG3U-0003Ct-UC
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 10:39:37 -0500
Message-ID: <4D73AAB6.8000407@web.de>
Date: Sun, 06 Mar 2011 16:39:34 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <AANLkTinReKqGNOHY9OWEn17JYA5ezm5dbtvZB2Ca2rs+@mail.gmail.com>
	<4D73A3CC.3080901@web.de>
	<AANLkTinAPxH4qs-PFFzv70Q+v1Ky_a=JXHOFvKONeQyh@mail.gmail.com>
In-Reply-To: <AANLkTinAPxH4qs-PFFzv70Q+v1Ky_a=JXHOFvKONeQyh@mail.gmail.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enigE833B143151158731A2ADC8F"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [PATCH 4/4] i8254: convert to qdev
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigE833B143151158731A2ADC8F
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 2011-03-06 16:35, Blue Swirl wrote:
> On Sun, Mar 6, 2011 at 5:10 PM, Jan Kiszka <jan.kiszka@web.de> wrote:
>> On 2011-02-13 22:10, Blue Swirl wrote:
>>> Convert to qdev. Don't expose PITState.
>>>
>>
>> ...
>>
>>> diff --git a/hw/pc.h b/hw/pc.h
>>> index 60f8c42..feb8a7a 100644
>>> --- a/hw/pc.h
>>> +++ b/hw/pc.h
>>> @@ -82,14 +82,23 @@ void isa_irq_handler(void *opaque, int n, int lev=
el);
>>>
>>>  #define PIT_FREQ 1193182
>>>
>>> -typedef struct PITState PITState;
>>> +static inline ISADevice *pit_init(int base, int irq)
>>> +{
>>> +    ISADevice *dev;
>>> +
>>> +    dev =3D isa_create("isa-pit");
>>> +    qdev_prop_set_uint32(&dev->qdev, "iobase", base);
>>> +    qdev_prop_set_uint32(&dev->qdev, "irq", irq);
>>> +    qdev_init_nofail(&dev->qdev);
>>> +
>>> +    return dev;
>>> +}
>>
>> This should be moved to i8254.c. We cannot compile the PIT out, and th=
e
>> above contains no board information. So I see no reason for this inlin=
ing.
>=20
> I see no reason for moving this back. In fact, if this was only used
> by PC, it could be moved to pc.c.

To my understanding, it's a factory helper for the PIT, avoiding
boilerplate code at the creator site. And if we get >1 users, this
cleanup would definitely pay off.

Jan


--------------enigE833B143151158731A2ADC8F
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk1zqrYACgkQitSsb3rl5xRUPwCg040q6yXihyZF9NkzW4WJ3w1n
bs4AoOOoal/2Prr7v2dwx2u9h2Vo7fs0
=RPoK
-----END PGP SIGNATURE-----

--------------enigE833B143151158731A2ADC8F--