From: Stefan Weil <weil@mail.berlios.de>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Herve Poussineau <hpoussin@reactos.org>,
qemu-devel@nongnu.org, Roy Tam <roytam@gmail.com>
Subject: Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h
Date: Sun, 06 Mar 2011 20:24:44 +0100 [thread overview]
Message-ID: <4D73DF7C.2060903@mail.berlios.de> (raw)
In-Reply-To: <AANLkTinQVETgX-23JNaM4qJLDH6t8nVDC9yUiNV37Ent@mail.gmail.com>
Am 06.03.2011 15:24, schrieb Roy Tam:
> Hi,
>
> 2011/3/6 Herve Poussineau<hpoussin@reactos.org>:
>
> FYI:
> [PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56858.html
> [PATCH 2/3] w32: Add macro timersub to sys/time.h
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56859.html
> [PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56860.html
Yes, this patch series also addresses the same problem (and one more)
in a better way: it did not add code, but removed a conditional compilation.
(my first try was identical to Herve's patch).
Stefan
>> From: Hervé Poussineau<hpoussin@reactos.org>
>>
>>
>> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>
>> ---
>> qemu-common.h | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/qemu-common.h b/qemu-common.h
>> index 40dad52..18e648f 100644
>> --- a/qemu-common.h
>> +++ b/qemu-common.h
>> @@ -33,6 +33,7 @@ typedef struct DeviceState DeviceState;
>> #include<unistd.h>
>> #include<fcntl.h>
>> #include<sys/stat.h>
>> +#include<sys/time.h>
>> #include<assert.h>
>>
>> #ifndef O_LARGEFILE
>> --
>> 1.6.0.2.GIT
>>
>>
>>
next prev parent reply other threads:[~2011-03-06 19:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-06 13:23 [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h Herve Poussineau
2011-03-06 14:22 ` Blue Swirl
2011-03-06 14:24 ` Roy Tam
2011-03-06 19:24 ` Stefan Weil [this message]
2011-03-06 20:25 ` Blue Swirl
2011-03-06 21:18 ` Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D73DF7C.2060903@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=blauwirbel@gmail.com \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
--cc=roytam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).