[Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h

[Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h

[Herve Poussineau]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 522 bytes --]

From: Hervé Poussineau <hpoussin@reactos.org>


Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 qemu-common.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/qemu-common.h b/qemu-common.h
index 40dad52..18e648f 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -33,6 +33,7 @@ typedef struct DeviceState DeviceState;
 #include <unistd.h>
 #include <fcntl.h>
 #include <sys/stat.h>
+#include <sys/time.h>
 #include <assert.h>
 
 #ifndef O_LARGEFILE
-- 
1.6.0.2.GIT

Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h

[Blue Swirl]

Thanks, applied.

On Sun, Mar 6, 2011 at 3:23 PM, Herve Poussineau <hpoussin@reactos.org> wrote:
> From: Hervé Poussineau <hpoussin@reactos.org>
>
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
>  qemu-common.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-common.h b/qemu-common.h
> index 40dad52..18e648f 100644
> --- a/qemu-common.h
> +++ b/qemu-common.h
> @@ -33,6 +33,7 @@ typedef struct DeviceState DeviceState;
>  #include <unistd.h>
>  #include <fcntl.h>
>  #include <sys/stat.h>
> +#include <sys/time.h>
>  #include <assert.h>
>
>  #ifndef O_LARGEFILE
> --
> 1.6.0.2.GIT
>
>
>

Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h

[Roy Tam]

Hi,

2011/3/6 Herve Poussineau <hpoussin@reactos.org>:

FYI:
[PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
http://www.mail-archive.com/qemu-devel@nongnu.org/msg56858.html
[PATCH 2/3] w32: Add macro timersub to sys/time.h
http://www.mail-archive.com/qemu-devel@nongnu.org/msg56859.html
[PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
http://www.mail-archive.com/qemu-devel@nongnu.org/msg56860.html

> From: Hervé Poussineau <hpoussin@reactos.org>
>
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
>  qemu-common.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-common.h b/qemu-common.h
> index 40dad52..18e648f 100644
> --- a/qemu-common.h
> +++ b/qemu-common.h
> @@ -33,6 +33,7 @@ typedef struct DeviceState DeviceState;
>  #include <unistd.h>
>  #include <fcntl.h>
>  #include <sys/stat.h>
> +#include <sys/time.h>
>  #include <assert.h>
>
>  #ifndef O_LARGEFILE
> --
> 1.6.0.2.GIT
>
>
>

Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h

[Stefan Weil]

Am 06.03.2011 15:24, schrieb Roy Tam:
> Hi,
>
> 2011/3/6 Herve Poussineau<hpoussin@reactos.org>:
>
> FYI:
> [PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56858.html
> [PATCH 2/3] w32: Add macro timersub to sys/time.h
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56859.html
> [PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56860.html

Yes, this patch series also addresses the same problem (and one more)
in a better way: it did not add code, but removed a conditional compilation.
(my first try was identical to Herve's patch).

Stefan

>> From: Hervé Poussineau<hpoussin@reactos.org>
>>
>>
>> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>
>> ---
>>   qemu-common.h |    1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/qemu-common.h b/qemu-common.h
>> index 40dad52..18e648f 100644
>> --- a/qemu-common.h
>> +++ b/qemu-common.h
>> @@ -33,6 +33,7 @@ typedef struct DeviceState DeviceState;
>>   #include<unistd.h>
>>   #include<fcntl.h>
>>   #include<sys/stat.h>
>> +#include<sys/time.h>
>>   #include<assert.h>
>>
>>   #ifndef O_LARGEFILE
>> --
>> 1.6.0.2.GIT
>>
>>
>>

Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h

[Blue Swirl]

On Sun, Mar 6, 2011 at 9:24 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> Am 06.03.2011 15:24, schrieb Roy Tam:
>>
>> Hi,
>>
>> 2011/3/6 Herve Poussineau<hpoussin@reactos.org>:
>>
>> FYI:
>> [PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56858.html
>> [PATCH 2/3] w32: Add macro timersub to sys/time.h
>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56859.html
>> [PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56860.html
>
> Yes, this patch series also addresses the same problem (and one more)
> in a better way: it did not add code, but removed a conditional compilation.
> (my first try was identical to Herve's patch).

As I replied to those, there are several problems with your approach.
Wrapping timersub() would solve the other problem nicely.

If we'd want to fake a POSIX-like programming environment, there are
other approaches like gnulib. But so far, the approach has been using
wrappers.

Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h

[Stefan Weil]

Am 06.03.2011 21:25, schrieb Blue Swirl:
> On Sun, Mar 6, 2011 at 9:24 PM, Stefan Weil<weil@mail.berlios.de>  wrote:
>> Am 06.03.2011 15:24, schrieb Roy Tam:
>>> Hi,
>>>
>>> 2011/3/6 Herve Poussineau<hpoussin@reactos.org>:
>>>
>>> FYI:
>>> [PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
>>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56858.html
>>> [PATCH 2/3] w32: Add macro timersub to sys/time.h
>>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56859.html
>>> [PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
>>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56860.html
>> Yes, this patch series also addresses the same problem (and one more)
>> in a better way: it did not add code, but removed a conditional compilation.
>> (my first try was identical to Herve's patch).
> As I replied to those, there are several problems with your approach.
> Wrapping timersub() would solve the other problem nicely.
>
> If we'd want to fake a POSIX-like programming environment, there are
> other approaches like gnulib. But so far, the approach has been using
> wrappers.

Obviously I missed your reply, but I just read it.

Patch 3/3 does not conflict with your intension.

It is still a better solution to include sys/time.h
and can be applied independent of the other
two patches.