* [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h
@ 2011-03-06 13:23 Herve Poussineau
2011-03-06 14:22 ` Blue Swirl
2011-03-06 14:24 ` Roy Tam
0 siblings, 2 replies; 6+ messages in thread
From: Herve Poussineau @ 2011-03-06 13:23 UTC (permalink / raw)
To: qemu-devel; +Cc: Herv� Poussineau
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=utf-8, Size: 522 bytes --]
From: Hervé Poussineau <hpoussin@reactos.org>
Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
qemu-common.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/qemu-common.h b/qemu-common.h
index 40dad52..18e648f 100644
--- a/qemu-common.h
+++ b/qemu-common.h
@@ -33,6 +33,7 @@ typedef struct DeviceState DeviceState;
#include <unistd.h>
#include <fcntl.h>
#include <sys/stat.h>
+#include <sys/time.h>
#include <assert.h>
#ifndef O_LARGEFILE
--
1.6.0.2.GIT
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h
2011-03-06 13:23 [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h Herve Poussineau
@ 2011-03-06 14:22 ` Blue Swirl
2011-03-06 14:24 ` Roy Tam
1 sibling, 0 replies; 6+ messages in thread
From: Blue Swirl @ 2011-03-06 14:22 UTC (permalink / raw)
To: Herve Poussineau; +Cc: qemu-devel
Thanks, applied.
On Sun, Mar 6, 2011 at 3:23 PM, Herve Poussineau <hpoussin@reactos.org> wrote:
> From: Hervé Poussineau <hpoussin@reactos.org>
>
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> qemu-common.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-common.h b/qemu-common.h
> index 40dad52..18e648f 100644
> --- a/qemu-common.h
> +++ b/qemu-common.h
> @@ -33,6 +33,7 @@ typedef struct DeviceState DeviceState;
> #include <unistd.h>
> #include <fcntl.h>
> #include <sys/stat.h>
> +#include <sys/time.h>
> #include <assert.h>
>
> #ifndef O_LARGEFILE
> --
> 1.6.0.2.GIT
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h
2011-03-06 13:23 [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h Herve Poussineau
2011-03-06 14:22 ` Blue Swirl
@ 2011-03-06 14:24 ` Roy Tam
2011-03-06 19:24 ` Stefan Weil
1 sibling, 1 reply; 6+ messages in thread
From: Roy Tam @ 2011-03-06 14:24 UTC (permalink / raw)
To: Herve Poussineau; +Cc: qemu-devel
Hi,
2011/3/6 Herve Poussineau <hpoussin@reactos.org>:
FYI:
[PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
http://www.mail-archive.com/qemu-devel@nongnu.org/msg56858.html
[PATCH 2/3] w32: Add macro timersub to sys/time.h
http://www.mail-archive.com/qemu-devel@nongnu.org/msg56859.html
[PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
http://www.mail-archive.com/qemu-devel@nongnu.org/msg56860.html
> From: Hervé Poussineau <hpoussin@reactos.org>
>
>
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
> qemu-common.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/qemu-common.h b/qemu-common.h
> index 40dad52..18e648f 100644
> --- a/qemu-common.h
> +++ b/qemu-common.h
> @@ -33,6 +33,7 @@ typedef struct DeviceState DeviceState;
> #include <unistd.h>
> #include <fcntl.h>
> #include <sys/stat.h>
> +#include <sys/time.h>
> #include <assert.h>
>
> #ifndef O_LARGEFILE
> --
> 1.6.0.2.GIT
>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h
2011-03-06 14:24 ` Roy Tam
@ 2011-03-06 19:24 ` Stefan Weil
2011-03-06 20:25 ` Blue Swirl
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Weil @ 2011-03-06 19:24 UTC (permalink / raw)
To: Blue Swirl; +Cc: Herve Poussineau, qemu-devel, Roy Tam
Am 06.03.2011 15:24, schrieb Roy Tam:
> Hi,
>
> 2011/3/6 Herve Poussineau<hpoussin@reactos.org>:
>
> FYI:
> [PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56858.html
> [PATCH 2/3] w32: Add macro timersub to sys/time.h
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56859.html
> [PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56860.html
Yes, this patch series also addresses the same problem (and one more)
in a better way: it did not add code, but removed a conditional compilation.
(my first try was identical to Herve's patch).
Stefan
>> From: Hervé Poussineau<hpoussin@reactos.org>
>>
>>
>> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>
>> ---
>> qemu-common.h | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/qemu-common.h b/qemu-common.h
>> index 40dad52..18e648f 100644
>> --- a/qemu-common.h
>> +++ b/qemu-common.h
>> @@ -33,6 +33,7 @@ typedef struct DeviceState DeviceState;
>> #include<unistd.h>
>> #include<fcntl.h>
>> #include<sys/stat.h>
>> +#include<sys/time.h>
>> #include<assert.h>
>>
>> #ifndef O_LARGEFILE
>> --
>> 1.6.0.2.GIT
>>
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h
2011-03-06 19:24 ` Stefan Weil
@ 2011-03-06 20:25 ` Blue Swirl
2011-03-06 21:18 ` Stefan Weil
0 siblings, 1 reply; 6+ messages in thread
From: Blue Swirl @ 2011-03-06 20:25 UTC (permalink / raw)
To: Stefan Weil; +Cc: Herve Poussineau, qemu-devel, Roy Tam
On Sun, Mar 6, 2011 at 9:24 PM, Stefan Weil <weil@mail.berlios.de> wrote:
> Am 06.03.2011 15:24, schrieb Roy Tam:
>>
>> Hi,
>>
>> 2011/3/6 Herve Poussineau<hpoussin@reactos.org>:
>>
>> FYI:
>> [PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56858.html
>> [PATCH 2/3] w32: Add macro timersub to sys/time.h
>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56859.html
>> [PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56860.html
>
> Yes, this patch series also addresses the same problem (and one more)
> in a better way: it did not add code, but removed a conditional compilation.
> (my first try was identical to Herve's patch).
As I replied to those, there are several problems with your approach.
Wrapping timersub() would solve the other problem nicely.
If we'd want to fake a POSIX-like programming environment, there are
other approaches like gnulib. But so far, the approach has been using
wrappers.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h
2011-03-06 20:25 ` Blue Swirl
@ 2011-03-06 21:18 ` Stefan Weil
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Weil @ 2011-03-06 21:18 UTC (permalink / raw)
To: Blue Swirl; +Cc: Herve Poussineau, qemu-devel, Roy Tam
Am 06.03.2011 21:25, schrieb Blue Swirl:
> On Sun, Mar 6, 2011 at 9:24 PM, Stefan Weil<weil@mail.berlios.de> wrote:
>> Am 06.03.2011 15:24, schrieb Roy Tam:
>>> Hi,
>>>
>>> 2011/3/6 Herve Poussineau<hpoussin@reactos.org>:
>>>
>>> FYI:
>>> [PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
>>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56858.html
>>> [PATCH 2/3] w32: Add macro timersub to sys/time.h
>>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56859.html
>>> [PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
>>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56860.html
>> Yes, this patch series also addresses the same problem (and one more)
>> in a better way: it did not add code, but removed a conditional compilation.
>> (my first try was identical to Herve's patch).
> As I replied to those, there are several problems with your approach.
> Wrapping timersub() would solve the other problem nicely.
>
> If we'd want to fake a POSIX-like programming environment, there are
> other approaches like gnulib. But so far, the approach has been using
> wrappers.
Obviously I missed your reply, but I just read it.
Patch 3/3 does not conflict with your intension.
It is still a better solution to include sys/time.h
and can be applied independent of the other
two patches.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-06 21:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-06 13:23 [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct timeval', used in vnc.h Herve Poussineau
2011-03-06 14:22 ` Blue Swirl
2011-03-06 14:24 ` Roy Tam
2011-03-06 19:24 ` Stefan Weil
2011-03-06 20:25 ` Blue Swirl
2011-03-06 21:18 ` Stefan Weil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).