From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34030 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PwLM6-0005yE-Lf
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 16:19:12 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PwLLM-00040K-JT
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 16:18:25 -0500
Received: from moutng.kundenserver.de ([212.227.126.187]:58805)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <weil@mail.berlios.de>) id 1PwLLM-0003zg-4n
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 16:18:24 -0500
Message-ID: <4D73FA1D.8040708@mail.berlios.de>
Date: Sun, 06 Mar 2011 22:18:21 +0100
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] WIN32: Add missing include for 'struct
	timeval', used in vnc.h
References: <1299417793-1720-1-git-send-email-hpoussin@reactos.org>
	<AANLkTinQVETgX-23JNaM4qJLDH6t8nVDC9yUiNV37Ent@mail.gmail.com>
	<4D73DF7C.2060903@mail.berlios.de>
	<AANLkTinnPSEMkc=G5K9e2fVrQ-fZj5b1Cm+hOOGFu9iq@mail.gmail.com>
In-Reply-To: <AANLkTinnPSEMkc=G5K9e2fVrQ-fZj5b1Cm+hOOGFu9iq@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: Herve Poussineau <hpoussin@reactos.org>, qemu-devel@nongnu.org, Roy Tam <roytam@gmail.com>

Am 06.03.2011 21:25, schrieb Blue Swirl:
> On Sun, Mar 6, 2011 at 9:24 PM, Stefan Weil<weil@mail.berlios.de>  wrote:
>> Am 06.03.2011 15:24, schrieb Roy Tam:
>>> Hi,
>>>
>>> 2011/3/6 Herve Poussineau<hpoussin@reactos.org>:
>>>
>>> FYI:
>>> [PATCH 1/3] w32: Add new directory hierarchy for MinGW extensions
>>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56858.html
>>> [PATCH 2/3] w32: Add macro timersub to sys/time.h
>>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56859.html
>>> [PATCH 3/3] osdep: Remove conditional compilation (fixes w32 compilation)
>>> http://www.mail-archive.com/qemu-devel@nongnu.org/msg56860.html
>> Yes, this patch series also addresses the same problem (and one more)
>> in a better way: it did not add code, but removed a conditional compilation.
>> (my first try was identical to Herve's patch).
> As I replied to those, there are several problems with your approach.
> Wrapping timersub() would solve the other problem nicely.
>
> If we'd want to fake a POSIX-like programming environment, there are
> other approaches like gnulib. But so far, the approach has been using
> wrappers.

Obviously I missed your reply, but I just read it.

Patch 3/3 does not conflict with your intension.

It is still a better solution to include sys/time.h
and can be applied independent of the other
two patches.