From: Anthony Liguori <anthony@codemonkey.ws>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 4/4] i8254: convert to qdev
Date: Sun, 06 Mar 2011 18:32:00 -0600 [thread overview]
Message-ID: <4D742780.1050000@codemonkey.ws> (raw)
In-Reply-To: <4D73FA15.8090107@web.de>
On 03/06/2011 03:18 PM, Jan Kiszka wrote:
>> It's far from academic as this is user-visible and visible via the
>> command line.
>>
> I thought it was stated before that there is no guarantee on the
> internal structure of our device tree as the user may explore it (as
> long as it's stable for the guest).
We have a lot of "unstable" interfaces that folks yell about every time
it changes (like the -help output). Providing a bad external interface
and justifying by saying its unstable is just asking for pain later.
> Regarding command line: What are
> your worries here? The user can't mess with built-in devices.
>
-global still applies to no_user devices.
> I still think we have more important things to improve than these
> cosmetic issues.
>
What does converting this device to qdev actually add other than an
interface that we're not going to be able to support long term?
Regards,
Anthony Liguori
> Jan
>
>
next prev parent reply other threads:[~2011-03-07 0:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-13 21:10 [Qemu-devel] [PATCH 4/4] i8254: convert to qdev Blue Swirl
2011-03-06 15:10 ` [Qemu-devel] " Jan Kiszka
2011-03-06 15:35 ` Blue Swirl
2011-03-06 15:39 ` Jan Kiszka
2011-03-06 16:06 ` Blue Swirl
2011-03-06 16:08 ` Jan Kiszka
2011-03-06 16:31 ` [Qemu-devel] " Anthony Liguori
2011-03-06 16:47 ` Blue Swirl
2011-03-06 17:35 ` Blue Swirl
2011-03-06 17:47 ` Anthony Liguori
2011-03-06 18:06 ` [Qemu-devel] " Jan Kiszka
2011-03-06 20:45 ` Anthony Liguori
2011-03-06 21:15 ` Blue Swirl
2011-03-06 21:18 ` Jan Kiszka
2011-03-07 0:32 ` Anthony Liguori [this message]
2011-03-07 7:58 ` Jan Kiszka
2011-03-07 14:57 ` Anthony Liguori
2011-03-07 15:46 ` Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D742780.1050000@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).