From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38489 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PwOMn-0004qu-VW
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 19:32:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PwOMm-0000JT-Re
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 19:32:05 -0500
Received: from mail-gy0-f173.google.com ([209.85.160.173]:55366)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PwOMm-0000J8-KM
	for qemu-devel@nongnu.org; Sun, 06 Mar 2011 19:32:04 -0500
Received: by gyd8 with SMTP id 8so1837911gyd.4
	for <qemu-devel@nongnu.org>; Sun, 06 Mar 2011 16:32:03 -0800 (PST)
Message-ID: <4D742780.1050000@codemonkey.ws>
Date: Sun, 06 Mar 2011 18:32:00 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <AANLkTinReKqGNOHY9OWEn17JYA5ezm5dbtvZB2Ca2rs+@mail.gmail.com>	<4D73B6CA.8070000@codemonkey.ws>	<AANLkTi=LHVBgZ+mxOXOidTNKrVavhBm+AL5Bwdf2V4A4@mail.gmail.com>
	<4D73C8CE.6080800@codemonkey.ws> <4D73CD43.1010004@web.de>
	<4D73F272.50105@codemonkey.ws> <4D73FA15.8090107@web.de>
In-Reply-To: <4D73FA15.8090107@web.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 4/4] i8254: convert to qdev
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

On 03/06/2011 03:18 PM, Jan Kiszka wrote:
>> It's far from academic as this is user-visible and visible via the
>> command line.
>>      
> I thought it was stated before that there is no guarantee on the
> internal structure of our device tree as the user may explore it (as
> long as it's stable for the guest).

We have a lot of "unstable" interfaces that folks yell about every time 
it changes (like the -help output).  Providing a bad external interface 
and justifying by saying its unstable is just asking for pain later.

>   Regarding command line: What are
> your worries here? The user can't mess with built-in devices.
>    

-global still applies to no_user devices.

> I still think we have more important things to improve than these
> cosmetic issues.
>    

What does converting this device to qdev actually add other than an 
interface that we're not going to be able to support long term?

Regards,

Anthony Liguori

> Jan
>
>