Re: [Qemu-devel] [PATCH 11/22] qapi: add signal support to core QMP server

[Anthony Liguori <anthony@codemonkey.ws>]

On 03/07/2011 07:21 AM, Stefan Hajnoczi wrote:
> On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori<aliguori@us.ibm.com>  wrote:
>    
>> diff --git a/qmp-core.h b/qmp-core.h
>> index e3235ec..5ce02f7 100644
>> --- a/qmp-core.h
>> +++ b/qmp-core.h
>> @@ -21,10 +21,65 @@ typedef struct QmpState QmpState;
>>   typedef void (QmpCommandFunc)(const QDict *, QObject **, Error **);
>>   typedef void (QmpStatefulCommandFunc)(QmpState *qmp__sess, const QDict *, QObject **, Error **);
>>
>> +typedef struct QmpSlot
>> +{
>> +    int handle;
>> +    void *func;
>>      
> This should be a void (*func)()

Technically void (*)() is an obsolete type in standard C.

I can switch to void (*)(void) but it requires casting and requires a 
typeof() :-/

Regards,

Anthony Liguori

>   pointer for architectures where
> function pointers don't fit into void * (e.g. ppc and itanium).
>
>    
>> +QmpSignal *qmp_signal_init(void);
>> +void qmp_signal_ref(QmpSignal *obj);
>> +void qmp_signal_unref(QmpSignal *obj);
>> +int qmp_signal_connect(QmpSignal *obj, void *func, void *opaque);
>>      
> Same function pointer issue here.
>
> Stefan
>
>