From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53814 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PwatB-0003Xu-DM
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:54:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PwatA-0002qq-CT
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:54:21 -0500
Received: from mail-gy0-f173.google.com ([209.85.160.173]:58052)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PwatA-0002qc-6U
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:54:20 -0500
Received: by gyd8 with SMTP id 8so2066029gyd.4
	for <qemu-devel@nongnu.org>; Mon, 07 Mar 2011 05:54:19 -0800 (PST)
Message-ID: <4D74E38A.90204@codemonkey.ws>
Date: Mon, 07 Mar 2011 07:54:18 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 10/22] qapi: add core QMP server support
References: <1299460984-15849-1-git-send-email-aliguori@us.ibm.com>	<1299460984-15849-11-git-send-email-aliguori@us.ibm.com>	<AANLkTiks5UZso66YVjN6mXf8R2wZ4CFpPnzQ3=wuGpu8@mail.gmail.com>	<4D74E01D.9020304@codemonkey.ws>
	<20110307134610.GP21899@redhat.com>
In-Reply-To: <20110307134610.GP21899@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Adam Litke <aglitke@linux.vnet.ibm.com>, Stefan Hajnoczi <stefanha@gmail.com>, qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

On 03/07/2011 07:46 AM, Daniel P. Berrange wrote:
> On Mon, Mar 07, 2011 at 07:39:41AM -0600, Anthony Liguori wrote:
>    
>> On 03/07/2011 07:09 AM, Stefan Hajnoczi wrote:
>>      
>>> On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori<aliguori@us.ibm.com>   wrote:
>>>        
>>>> +char *qobject_as_string(QObject *obj)
>>>> +{
>>>> +    char buffer[1024];
>>>> +
>>>> +    switch (qobject_type(obj)) {
>>>> +    case QTYPE_QINT:
>>>> +        snprintf(buffer, sizeof(buffer), "%" PRId64,
>>>> +                 qint_get_int(qobject_to_qint(obj)));
>>>> +        return qemu_strdup(buffer);
>>>> +    case QTYPE_QSTRING:
>>>> +        return qemu_strdup(qstring_get_str(qobject_to_qstring(obj)));
>>>> +    case QTYPE_QFLOAT:
>>>> +        snprintf(buffer, sizeof(buffer), "%.17g",
>>>> +                 qfloat_get_double(qobject_to_qfloat(obj)));
>>>> +        return qemu_strdup(buffer);
>>>>          
>>> qemu_asprintf() would be a nice helper function to have ;).
>>>        
>> Indeed :-)
>>      
> Since you've introduced glib, you get that function for free:
>
>      g_strdup_printf()/g_strdup_vprintf()
>
> similarly qemu_strdup&  malloc related friends could be replaced with
> the equivalent glib functions.
>    

Good point.

Regards,

Anthony Liguori

> Regards,
> Daniel
>