From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=43124 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pwaub-0004Un-Ii for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:55:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pwaua-0003WA-Bu for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:55:49 -0500 Received: from mail-yw0-f45.google.com ([209.85.213.45]:47237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pwaua-0003Vt-4i for qemu-devel@nongnu.org; Mon, 07 Mar 2011 08:55:48 -0500 Received: by ywl41 with SMTP id 41so2024419ywl.4 for ; Mon, 07 Mar 2011 05:55:47 -0800 (PST) Message-ID: <4D74E3E2.3010004@codemonkey.ws> Date: Mon, 07 Mar 2011 07:55:46 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 01/22] Add hard build dependency on glib References: <1299460984-15849-1-git-send-email-aliguori@us.ibm.com> <1299460984-15849-2-git-send-email-aliguori@us.ibm.com> <20110307105917.GG21899@redhat.com> In-Reply-To: <20110307105917.GG21899@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, Adam Litke , Markus Armbruster , Luiz Capitulino On 03/07/2011 04:59 AM, Daniel P. Berrange wrote: > On Sun, Mar 06, 2011 at 07:22:43PM -0600, Anthony Liguori wrote: > >> GLib is an extremely common library that has a portable thread implementation >> along with tons of other goodies. >> >> GLib and GObject have a fantastic amount of infrastructure we can leverage in >> QEMU including an object oriented programming infrastructure. >> >> Short term, it has a very nice thread pool implementation that we could leverage >> in something like virtio-9p. It also has a test harness implementation that >> this series will use. >> >> Signed-off-by: Anthony Liguori >> >> diff --git a/Makefile b/Makefile >> index eca4c76..6b1d716 100644 >> --- a/Makefile >> +++ b/Makefile >> @@ -104,6 +104,8 @@ audio/audio.o audio/fmodaudio.o: QEMU_CFLAGS += $(FMOD_CFLAGS) >> >> QEMU_CFLAGS+=$(CURL_CFLAGS) >> >> +QEMU_CFLAGS+=$(GLIB_CFLAGS) >> + >> ui/cocoa.o: ui/cocoa.m >> >> ui/sdl.o audio/sdlaudio.o ui/sdl_zoom.o baum.o: QEMU_CFLAGS += $(SDL_CFLAGS) >> diff --git a/Makefile.objs b/Makefile.objs >> index 9e98a66..0ba02c7 100644 >> --- a/Makefile.objs >> +++ b/Makefile.objs >> @@ -322,3 +322,5 @@ vl.o: QEMU_CFLAGS+=$(GPROF_CFLAGS) >> >> vl.o: QEMU_CFLAGS+=$(SDL_CFLAGS) >> >> +vl.o: QEMU_CFLAGS+=$(GLIB_CFLAGS) >> + >> diff --git a/Makefile.target b/Makefile.target >> index 220589e..0bd42da 100644 >> --- a/Makefile.target >> +++ b/Makefile.target >> @@ -204,6 +204,7 @@ QEMU_CFLAGS += $(VNC_TLS_CFLAGS) >> QEMU_CFLAGS += $(VNC_SASL_CFLAGS) >> QEMU_CFLAGS += $(VNC_JPEG_CFLAGS) >> QEMU_CFLAGS += $(VNC_PNG_CFLAGS) >> +QEMU_CFLAGS += $(GLIB_CFLAGS) >> >> # xen backend driver support >> obj-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o >> diff --git a/configure b/configure >> index ef51a58..e1305ae 100755 >> --- a/configure >> +++ b/configure >> @@ -1662,6 +1662,18 @@ EOF >> fi >> >> ########################################## >> +# glib support probe >> +if $pkg_config --modversion gthread-2.0> /dev/null 2>&1 ; then >> + glib_cflags=`$pkg_config --cflags gthread-2.0 2>/dev/null` >> + glib_libs=`$pkg_config --libs gthread-2.0 2>/dev/null` >> + libs_softmmu="$glib_libs $libs_softmmu" >> + libs_tools="$glib_libs $libs_softmmu" >> +else >> + echo "glib-2.0 required to compile QEMU" >> + exit 1 >> +fi >> > It would be preferable to specify an explicit '--atleast-version=2.xxx' > since I doubt QEMU will work with all 2.x versions of glib. Obviously > the min version will limit what platforms QEMU can easily be deployed > on, so we need to be as flexible as possible. > Yeah, right now, we don't really depend on a specific version but it would be good to have for when we do. The testing bits are not part of the main build (they depend on a pretty recent glib). Regards, Anthony Liguori > Regards, > Daniel >