From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41741 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PwcIj-0001sz-BC
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 10:24:53 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PwcIh-0001Y7-Vi
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 10:24:49 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42663)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PwcIh-0001Xk-Ky
	for qemu-devel@nongnu.org; Mon, 07 Mar 2011 10:24:47 -0500
Message-ID: <4D74F8AE.8000205@redhat.com>
Date: Mon, 07 Mar 2011 16:24:30 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
References: <1299158036-18481-1-git-send-email-Jes.Sorensen@redhat.com>
	<4D74ACFE.40908@redhat.com>
In-Reply-To: <4D74ACFE.40908@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2] Improve error handling in
	do_snapshot_blkdev()
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On 03/07/11 11:01, Kevin Wolf wrote:
> Am 03.03.2011 14:13, schrieb Jes.Sorensen@redhat.com:
>> @@ -591,6 +592,12 @@ int do_snapshot_blkdev(Monitor *mon, const QDict *qdict, QObject **ret_data)
>>          goto out;
>>      }
>>  
>> +    strncpy(old_filename, bs->filename, sizeof(old_filename));
>> +    old_filename[1023] = '\0';
> 
> qemu has pstrcpy() from cutils.c for this.

I'll change it to use pstrcpy().

>> -        abort();
>> +        qerror_report(QERR_OPEN_FILE_FAILED, filename);
>> +        error_printf("do_snapshot_blkdev(): Unable to open newly created "
>> +                     "snapshot file: \n");
>> +        error_printf(" %s. Attempting to revert to original image %s\n",
> 
> That should probably be a colon in "%s: Attempting..." Also, is the
> leading space intentional?

The colon is already there prior to the \n" on the previous printf line.
The space was intentional, but maybe that will just confuse people so I
will remove it. I added a colon after image: in the last line instead.

Look out for v3.


Cheers,
Jes