From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33213 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PwcZh-0002Ux-8S for qemu-devel@nongnu.org; Mon, 07 Mar 2011 10:42:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PwcZf-0005DK-Sq for qemu-devel@nongnu.org; Mon, 07 Mar 2011 10:42:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27295) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PwcZf-0005D3-Jc for qemu-devel@nongnu.org; Mon, 07 Mar 2011 10:42:19 -0500 Message-ID: <4D74FD4E.4080901@redhat.com> Date: Mon, 07 Mar 2011 16:44:14 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1299511653-11357-1-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: <1299511653-11357-1-git-send-email-Jes.Sorensen@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH v3] Improve error handling in do_snapshot_blkdev() List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes.Sorensen@redhat.com Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Am 07.03.2011 16:27, schrieb Jes.Sorensen@redhat.com: > From: Jes Sorensen > > In case we cannot open the newly created snapshot image, try to fall > back to the original image file and continue running on that, which > should prevent the guest from aborting. > > This is a corner case which can happen if the admin by mistake > specifies the snapshot file on a virtual file system which does not > support O_DIRECT. bdrv_create() does not use O_DIRECT, but the > following open in bdrv_open() does and will then fail. > > Signed-off-by: Jes Sorensen Thanks, applied to the block branch. Kevin