From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=56033 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PwpCV-0000gs-1g for qemu-devel@nongnu.org; Tue, 08 Mar 2011 00:11:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PwpCU-0003vK-6G for qemu-devel@nongnu.org; Tue, 08 Mar 2011 00:11:15 -0500 Received: from e35.co.us.ibm.com ([32.97.110.153]:36322) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PwpCT-0003ux-Vf for qemu-devel@nongnu.org; Tue, 08 Mar 2011 00:11:14 -0500 Received: from d03relay04.boulder.ibm.com (d03relay04.boulder.ibm.com [9.17.195.106]) by e35.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p284u7ZX001838 for ; Mon, 7 Mar 2011 21:56:07 -0700 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay04.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p285B265108884 for ; Mon, 7 Mar 2011 22:11:03 -0700 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p285B1gg003596 for ; Mon, 7 Mar 2011 22:11:02 -0700 Message-ID: <4D75BA5E.1040106@linux.vnet.ibm.com> Date: Mon, 07 Mar 2011 21:10:54 -0800 From: "Venkateswararao Jujjuri (JV)" MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [V7 PATCH 3/9] virtio-9p: Provide chroot worker side interfaces References: <1299230756-1644-1-git-send-email-mohan@in.ibm.com> <1299230756-1644-4-git-send-email-mohan@in.ibm.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: "M. Mohan Kumar" , qemu-devel@nongnu.org On 3/4/2011 2:53 AM, Stefan Hajnoczi wrote: > On Fri, Mar 4, 2011 at 9:25 AM, M. Mohan Kumar wrote: >> +static int chroot_do_open(V9fsFileObjectRequest *request) >> +{ >> + int fd; >> + fd = open(request->path.path, request->data.flags); >> + if (fd < 0) { >> + fd = -errno; >> + } >> + return fd; >> +} > > How do access checks work without fsuid/fsgid being set? VirtFS access checks are done on the cleint. Server just does what client asked for.. as long as the operations on the exported region. - JV > > Stefan >