From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=41524 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PxBca-0006q1-MA
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 00:07:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1PxBcZ-000677-MO
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 00:07:40 -0500
Received: from [222.73.24.84] (port=50648 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1PxBcZ-00065z-EX
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 00:07:39 -0500
Message-ID: <4D770A51.6050509@cn.fujitsu.com>
Date: Wed, 09 Mar 2011 13:04:17 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] `qdev_free` when unplug a pci device
References: <1298396180-23734-1-git-send-email-wdauchy@gmail.com>
	<20110223025001.GC19727@valinux.co.jp>
	<m3hbbvm9uo.fsf@blackfin.pond.sub.org>
	<4D6B0DF8.5000407@cn.fujitsu.com>
	<20110309040814.GM23238@us.ibm.com>
In-Reply-To: <20110309040814.GM23238@us.ibm.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ISO-8859-1
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: Isaku Yamahata <yamahata@valinux.co.jp>, Gerd Hoffmann <kraxel@redhat.com>, Markus Armbruster <armbru@redhat.com>, William Dauchy <wdauchy@gmail.com>, qemu-devel@nongnu.org

At 03/09/2011 12:08 PM, Ryan Harper Write:
> * Wen Congyang <wency@cn.fujitsu.com> [2011-02-27 20:56]:
>> Hi Markus Armbruster
>>
>> At 02/23/2011 04:30 PM, Markus Armbruster Write:
>>> Isaku Yamahata <yamahata@valinux.co.jp> writes:
>>>
>>
>> <snip>
>>
>>>
>>> I don't think this patch is correct.  Let me explain.
>>>
>>> Device hot unplug is *not* guaranteed to succeed.
>>>
>>> For some buses, such as USB, it always succeeds immediately, i.e. when
>>> the device_del monitor command finishes, the device is gone.  Live is
>>> good.
>>>
>>> But for PCI, device_del merely initiates the ACPI unplug rain dance.  It
>>> doesn't wait for the dance to complete.  Why?  The dance can take an
>>> unpredictable amount of time, including forever.
>>>
>>> Problem: Subsequent device_add can fail if it reuses the qdev ID or PCI
>>> slot, and the unplug has not yet completed (race condition), or it
>>> failed.  Yes, Virginia, PCI hotplug *can* fail.
>>>
>>> When unplug succeeds, the qdev is automatically destroyed.
>>> pciej_write() does that for PIIX4.  Looks like pcie_cap_slot_event()
>>> does it for PCIE.
>>
>> I got a similar problem.  When I unplug a pci device by hand, it works
>> as expected, and I can hotplug it again. But when I use a srcipt to
>> do the same thing, sometimes it failed. I think I may find another bug.
>>
>> Steps to reproduce this bug:
>> 1. cat ./test-e1000.sh # RHEL6RC is domain name
>>    #! /bin/bash
>>
>>    while true; do
>>            virsh attach-interface RHEL6RC network default --mac 52:54:00:1f:db:c7 --model e1000
>>            if [[ $? -ne 0 ]]; then
>>                    break
>>            fi
>>            virsh detach-interface RHEL6RC network --mac 52:54:00:1f:db:c7
>>            if [[ $? -ne 0 ]]; then
>>                    break
>>            fi
>>            sleep 5
> 
> How do you know that the guest has responded at this point before you
> attempt to attach again at the top of the loop.  Any attach/detach
> requires the guest to respond to the request and it may not respond at
> all.

When I attach/detach interface by hand, it works fine: I can see the new interface
when I attach it, and it disapears when I detached it.


> 
>