From: Kevin Wolf <kwolf@redhat.com>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v5] PING: Fix ATA SMART and CHECK POWER MODE
Date: Wed, 09 Mar 2011 10:32:26 +0100 [thread overview]
Message-ID: <4D77492A.9060606@redhat.com> (raw)
In-Reply-To: <20110309042616.GN23238@us.ibm.com>
Am 09.03.2011 05:26, schrieb Ryan Harper:
> * Brian Wheeler <bdwheele@indiana.edu> [2011-03-01 07:35]:
>> This patch fixes two things:
>>
>> 1) CHECK POWER MODE
>>
>> The error return value wasn't always zero, so it would show up as
>> offline. Error is now explicitly set to zero.
>>
>> 2) SMART
>>
>> The smart values that were returned were invalid and tools like skdump
>> would not recognize that the smart data was actually valid and would
>> dump weird output. The data has been fixed up and raw value support
>> was added. Tools like skdump and palimpsest work as expected.
>>
>> v5 changes: rebase
>> v4 changes: incorporate changes from Ryan Harper
>> v3 changes: don't reformat code I didn't change
>> v2 changes: use single structure instead of one for thresholds and one
>> for data.
>>
>
> Sorry, haven't had a chance to catch up on qemu-devel, meant to respond
> sooner. Changes look good.
>
> Acked-by: Ryan Harper <ryanh@us.ibm.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2011-03-09 9:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-01 13:30 [Qemu-devel] [PATCH v5] PING: Fix ATA SMART and CHECK POWER MODE Brian Wheeler
2011-03-06 19:26 ` Aurelien Jarno
2011-03-07 8:28 ` Kevin Wolf
2011-03-07 9:51 ` Stefan Hajnoczi
2011-03-09 4:26 ` Ryan Harper
2011-03-09 9:32 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D77492A.9060606@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ryanh@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).