From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=33980 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PxFiu-0002W6-Jf
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 04:30:29 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PxFit-0003CJ-BX
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 04:30:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:29750)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1PxFit-0003CF-0v
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 04:30:27 -0500
Message-ID: <4D77492A.9060606@redhat.com>
Date: Wed, 09 Mar 2011 10:32:26 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v5] PING: Fix ATA SMART and CHECK POWER MODE
References: <1298986223.419.0.camel@nibbler.dlib.indiana.edu>
	<20110309042616.GN23238@us.ibm.com>
In-Reply-To: <20110309042616.GN23238@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

Am 09.03.2011 05:26, schrieb Ryan Harper:
> * Brian Wheeler <bdwheele@indiana.edu> [2011-03-01 07:35]:
>> This patch fixes two things:
>>
>>  1) CHECK POWER MODE
>>
>> The error return value wasn't always zero, so it would show up as
>> offline.  Error is now explicitly set to zero.
>>
>>  2) SMART
>>
>> The smart values that were returned were invalid and tools like skdump
>> would not recognize that the smart data was actually valid and would
>> dump weird output.  The data has been fixed up and raw value support
>> was added.  Tools like skdump and palimpsest work as expected.
>>
>> v5 changes:  rebase
>> v4 changes:  incorporate changes from Ryan Harper
>> v3 changes:  don't reformat code I didn't change
>> v2 changes:  use single structure instead of one for thresholds and one
>> for data.
>>
> 
> Sorry, haven't had a chance to catch up on qemu-devel, meant to respond
> sooner.  Changes look good.
> 
> Acked-by: Ryan Harper <ryanh@us.ibm.com>

Thanks, applied to the block branch.

Kevin