From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46993 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PxGW5-0001Je-65
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 05:21:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PxGW3-0006gN-Q9
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 05:21:17 -0500
Received: from mx1.redhat.com ([209.132.183.28]:14260)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PxGW3-0006gD-FW
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 05:21:15 -0500
Message-ID: <4D77548A.3030506@redhat.com>
Date: Wed, 09 Mar 2011 11:20:58 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v3] Improve error handling in
	do_snapshot_blkdev()
References: <1299511653-11357-1-git-send-email-Jes.Sorensen@redhat.com>	<4D75092F.1020107@codemonkey.ws>	<4D750A4B.1070304@redhat.com>	<4D751A2E.7030309@codemonkey.ws>
	<4D75E7D0.90900@redhat.com>	<4D76323D.8050906@codemonkey.ws>
	<4D765CFF.3090909@redhat.com> <4D766B6F.9060307@codemonkey.ws>
In-Reply-To: <4D766B6F.9060307@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On 03/08/11 18:46, Anthony Liguori wrote:
> On 03/08/2011 10:44 AM, Jes Sorensen wrote:
>> On 03/08/11 14:42, Anthony Liguori wrote:
>> It kinda sorta covers it. The problem with that is that you then have to
>> do a string match of the return values to determine which of the cases
>> happened, which isn't very nice. But I guess we can do that for now.
> 
> Right, but this can be done in the HMP command such that the HMP command
> still prints out the warning message.
> 
> The key is to have well documented error semantics where the various
> cases can be distinguished because then we can ensure that we can not
> only print out a nice error message in HMP, but that a remote QMP client
> (like libvirt) can also generate a high quality error message.

Have a look at v4 then, I've changed it to report errors back according
to this.

Jes