From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57283 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxGiZ-0001M6-Ed for qemu-devel@nongnu.org; Wed, 09 Mar 2011 05:34:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PxGiY-0001oj-8m for qemu-devel@nongnu.org; Wed, 09 Mar 2011 05:34:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8538) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PxGiX-0001oA-VR for qemu-devel@nongnu.org; Wed, 09 Mar 2011 05:34:10 -0500 Message-ID: <4D77578F.5000905@redhat.com> Date: Wed, 09 Mar 2011 11:33:51 +0100 From: Jes Sorensen MIME-Version: 1.0 References: <1299528642-23631-1-git-send-email-mdroth@linux.vnet.ibm.com> <1299528642-23631-4-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1299528642-23631-4-git-send-email-mdroth@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC][PATCH v7 03/16] Make qemu timers available for tools List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, markus_mueller@de.ibm.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, abeekhof@redhat.com On 03/07/11 21:10, Michael Roth wrote: > To be able to use qemu_mod_timer() and friends to register timeout > events for virtagent's qemu-va tool, we need to do the following: > > Move several blocks of code out of cpus.c that handle initialization > of qemu's io_thread_fd and working with it via > qemu_notify_event()/qemu_event_read()/etc, and make them accessible > as backend functions to both the emulator code and qemu-tool.c via > wrapper functions within cpus.c and qemu-tool.c, respectively. These > have been added to qemu-ioh.c, where similar treatment was given to > qemu_set_fd_handler() and friends. > > Some of these wrapper functions lack declarations when being > built into tools, so we add those via qemu-tool.h, which can be included > by a tool to access them. With these changes we can drive timers in a > tool linking it against qemu-timer.o and then implementing something > similar to the main i/o loop in vl.c: > [snip] > diff --git a/qemu-ioh.c b/qemu-ioh.c > index cc71470..5c3f94c 100644 > --- a/qemu-ioh.c > +++ b/qemu-ioh.c > @@ -113,3 +117,94 @@ void qemu_process_fd_handlers2(void *ioh_record_list, const fd_set *rfds, > } > } > } > + > +#ifndef _WIN32 > +void iothread_event_increment(int *io_thread_fd) Please move these functions into posix/w32 specific files so we don't get anymore ugly #ifdefs. It would be good if we could use a wrapper struct as well to hide the different data types so we don't need #ifdefs in the calling code as well. Cheers, Jes