From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47102 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxJ6X-0002oe-JR for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:07:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PxJ6V-0004LX-Jq for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:07:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PxJ6V-0004LL-BQ for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:07:03 -0500 Message-ID: <4D777B63.2010902@redhat.com> Date: Wed, 09 Mar 2011 14:06:43 +0100 From: Jes Sorensen MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [RFC][PATCH v7 03/16] Make qemu timers available for tools References: <1299528642-23631-1-git-send-email-mdroth@linux.vnet.ibm.com> <1299528642-23631-4-git-send-email-mdroth@linux.vnet.ibm.com> <4D77578F.5000905@redhat.com> <4D777AD3.6040502@linux.vnet.ibm.com> In-Reply-To: <4D777AD3.6040502@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, abeekhof@redhat.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, markus_mueller@de.ibm.com On 03/09/11 14:04, Michael Roth wrote: > On 03/09/2011 04:33 AM, Jes Sorensen wrote: >>> diff --git a/qemu-ioh.c b/qemu-ioh.c >>> index cc71470..5c3f94c 100644 >>> --- a/qemu-ioh.c >>> +++ b/qemu-ioh.c >>> @@ -113,3 +117,94 @@ void qemu_process_fd_handlers2(void >>> *ioh_record_list, const fd_set *rfds, >>> } >>> } >>> } >>> + >>> +#ifndef _WIN32 >>> +void iothread_event_increment(int *io_thread_fd) >> >> Please move these functions into posix/w32 specific files so we don't >> get anymore ugly #ifdefs. It would be good if we could use a wrapper >> struct as well to hide the different data types so we don't need #ifdefs >> in the calling code as well. > > Yup, meant to add this to the TODO. I may end up sending these general > tools changes out in a separate patchset since they seem to be in > conflict with quite of few patches floating around the list. Either way > I'll make sure to get these cleaned up and tested a bit a more. Sounds great! Since they are not directly part of virtagent you should be able to push them in soon too. Cheers, Jes