Re: [Qemu-devel] Re: [RFC][PATCH v7 05/16] virtagent: common helpers and init routines

[Michael Roth <mdroth@linux.vnet.ibm.com>]

On 03/09/2011 04:38 AM, Jes Sorensen wrote:
> On 03/07/11 21:10, Michael Roth wrote:
>> +#define VA_PIDFILE "/var/run/qemu-va.pid"
>> +#define VA_HDR_LEN_MAX 4096 /* http header limit */
>> +#define VA_CONTENT_LEN_MAX 2*1024*1024 /* rpc/http send limit */
>> +#define VA_CLIENT_JOBS_MAX 5 /* max client rpcs we can queue */
>> +#define VA_SERVER_JOBS_MAX 5 /* max server rpcs we can queue */
>> +#define VA_SERVER_TIMEOUT_MS 5 * 1000
>> +#define VA_CLIENT_TIMEOUT_MS 5 * 1000
>> +#define VA_SENTINEL 0xFF
>> +#define VA_BAUDRATE B38400 /* for isa-serial channels */
>> +
>
> I've been after these before - please put the ones that make sense to
> tune into a config file, and the same with the pidfile.

I think my contention last time was that most of these weren't meant to 
be tweakable by an end-user, they're mainly just to avoid using magic 
numbers everywhere.

For stuff that is, like the pid file and socket/port paths, these would 
be the defaults, and the option to override them would be provided via 
the command line (virtagent chardev options on the host, command options 
on the guest).

I did plan to make the distinction between the 2 clearer though, by 
adding a DEFAULT_* or something along that line. Will get those in for 
the next pass.

>
> Cheers,
> Jes
>
>