From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=58303 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxJGu-00013H-2S for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:17:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PxJGs-0006Gq-RP for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:17:47 -0500 Received: from e3.ny.us.ibm.com ([32.97.182.143]:52141) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PxJGs-0006Ge-OT for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:17:46 -0500 Received: from d01dlp01.pok.ibm.com (d01dlp01.pok.ibm.com [9.56.224.56]) by e3.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p29CvX8M026719 for ; Wed, 9 Mar 2011 07:57:33 -0500 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp01.pok.ibm.com (Postfix) with ESMTP id E6E3D38C8039 for ; Wed, 9 Mar 2011 08:17:42 -0500 (EST) Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p29DHilK317216 for ; Wed, 9 Mar 2011 08:17:45 -0500 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p29DHhMX026845 for ; Wed, 9 Mar 2011 06:17:44 -0700 Message-ID: <4D777DF5.2060404@linux.vnet.ibm.com> Date: Wed, 09 Mar 2011 07:17:41 -0600 From: Michael Roth MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [RFC][PATCH v7 05/16] virtagent: common helpers and init routines References: <1299528642-23631-1-git-send-email-mdroth@linux.vnet.ibm.com> <1299528642-23631-6-git-send-email-mdroth@linux.vnet.ibm.com> <4D77588B.8070901@redhat.com> In-Reply-To: <4D77588B.8070901@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jes Sorensen Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, abeekhof@redhat.com, qemu-devel@nongnu.org, aliguori@linux.vnet.ibm.com, markus_mueller@de.ibm.com On 03/09/2011 04:38 AM, Jes Sorensen wrote: > On 03/07/11 21:10, Michael Roth wrote: >> +#define VA_PIDFILE "/var/run/qemu-va.pid" >> +#define VA_HDR_LEN_MAX 4096 /* http header limit */ >> +#define VA_CONTENT_LEN_MAX 2*1024*1024 /* rpc/http send limit */ >> +#define VA_CLIENT_JOBS_MAX 5 /* max client rpcs we can queue */ >> +#define VA_SERVER_JOBS_MAX 5 /* max server rpcs we can queue */ >> +#define VA_SERVER_TIMEOUT_MS 5 * 1000 >> +#define VA_CLIENT_TIMEOUT_MS 5 * 1000 >> +#define VA_SENTINEL 0xFF >> +#define VA_BAUDRATE B38400 /* for isa-serial channels */ >> + > > I've been after these before - please put the ones that make sense to > tune into a config file, and the same with the pidfile. I think my contention last time was that most of these weren't meant to be tweakable by an end-user, they're mainly just to avoid using magic numbers everywhere. For stuff that is, like the pid file and socket/port paths, these would be the defaults, and the option to override them would be provided via the command line (virtagent chardev options on the host, command options on the guest). I did plan to make the distinction between the 2 clearer though, by adding a DEFAULT_* or something along that line. Will get those in for the next pass. > > Cheers, > Jes > >