From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40254 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxJRl-0001mw-1I for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:29:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PxJRj-0000n1-RE for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:29:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:48985) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PxJRj-0000md-Gk for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:28:59 -0500 Message-ID: <4D778094.8060803@redhat.com> Date: Wed, 09 Mar 2011 15:28:52 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 14/22] qapi: add query-version QMP command References: <1299460984-15849-1-git-send-email-aliguori@us.ibm.com> <1299460984-15849-15-git-send-email-aliguori@us.ibm.com> <4D74E08F.3080309@codemonkey.ws> In-Reply-To: <4D74E08F.3080309@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Stefan Hajnoczi , Luiz Capitulino , qemu-devel@nongnu.org, Markus Armbruster , Adam Litke On 03/07/2011 03:41 PM, Anthony Liguori wrote: > On 03/07/2011 07:35 AM, Stefan Hajnoczi wrote: >> On Mon, Mar 7, 2011 at 1:22 AM, Anthony Liguori >> wrote: >>> diff --git a/qmp-schema.json b/qmp-schema.json >>> index e69de29..b343f5e 100644 >>> --- a/qmp-schema.json >>> +++ b/qmp-schema.json >>> @@ -0,0 +1,38 @@ >>> +# *-*- Mode: Python -*-* >> By the way JSON does not seem to support comments (neither /* */ nor >> #). So this comment feature you're using is an extension to JSON. > > Yeah, it's only loosely JSON as I don't use a JSON parser. Goes kind of against all the buzzwords you're letting fly here... -- error compiling committee.c: too many arguments to function