From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34328 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PxJTq-0002dZ-JC
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:31:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1PxJTo-0001V7-K0
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:31:10 -0500
Received: from mx1.redhat.com ([209.132.183.28]:24026)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1PxJTo-0001Um-Au
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:31:08 -0500
Message-ID: <4D778117.9060505@redhat.com>
Date: Wed, 09 Mar 2011 15:31:03 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 19/22] qapi: add QMP put-event command
References: <1299460984-15849-1-git-send-email-aliguori@us.ibm.com>
	<1299460984-15849-20-git-send-email-aliguori@us.ibm.com>
In-Reply-To: <1299460984-15849-20-git-send-email-aliguori@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>, qemu-devel@nongnu.org, Adam Litke <aglitke@linux.vnet.ibm.com>

On 03/07/2011 03:23 AM, Anthony Liguori wrote:
> This is needed for libqmp to support events.  put-event is used to disconnect
> from signals.
>
> Signed-off-by: Anthony Liguori<aliguori@us.ibm.com>
>
> diff --git a/qmp-schema.json b/qmp-schema.json
> index 3f2dd4e..a13885f 100644
> --- a/qmp-schema.json
> +++ b/qmp-schema.json
> @@ -58,3 +58,18 @@
>   # Since: 0.14.0
>   ##
>   [ 'qmp_capabilities', {}, {}, 'none' ]
> +
> +##
> +# @put_event:
> +#
> +# Disconnect a signal.  This command is used to disconnect from a signal based
> +# on the handle returned by a signal accessor.
> +#
> +# @tag: the handle returned by a signal accessor.
> +#
> +# Returns: Nothing on success.
> +#          If @tag is not a valid handle, InvalidParameterValue
> +#
> +# Since: 0.15.0
> +##
> +[ 'put-event', {'tag': 'int'}, {}, 'none' ]

Why is tag an int?  don't we use strings for command ids and similar?

Also could be better named, disconnect-event or unlisten-event.

-- 
error compiling committee.c: too many arguments to function