From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36461 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PxJug-0002qB-Fn
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:58:55 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1PxJuf-000322-AV
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:58:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:54807)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <avi@redhat.com>) id 1PxJuf-00031k-1d
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 08:58:53 -0500
Message-ID: <4D778797.9090602@redhat.com>
Date: Wed, 09 Mar 2011 15:58:47 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 19/22] qapi: add QMP put-event command
References: <1299460984-15849-1-git-send-email-aliguori@us.ibm.com>	<1299460984-15849-20-git-send-email-aliguori@us.ibm.com>
	<4D778117.9060505@redhat.com> <4D778545.7040403@codemonkey.ws>
In-Reply-To: <4D778545.7040403@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Adam Litke <aglitke@linux.vnet.ibm.com>, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

On 03/09/2011 03:48 PM, Anthony Liguori wrote:
>>> +[ 'put-event', {'tag': 'int'}, {}, 'none' ]
>>
>> Why is tag an int?
> +##
>
> It's a handle so the type doesn't matter as long as I can make sure 
> values are unique.  ints are easier to work with because they don't 
> require memory allocation.

I think it's nicer for the client to use a string.  Instead of a global 
ID allocator, it can use unique IDs or unique prefixes + local IDs.  
Should also aid a little in debugging.

>
>>   don't we use strings for command ids and similar?
>
> id's can be any valid JSON value.
>
> But a handle is not the same thing as an id.

Why not?

I hope handles are client-provided?

>
>> Also could be better named, disconnect-event or unlisten-event.
>
> I was going for symmetry with the signal accessors which are typically 
> in the format 'get-block-io-error-event'.
>
> Maybe it would be better to do 'connect-block-io-error-event' and 
> 'disconnect-event'?

Yes.

But I'm confused, do we have a per-event command on the wire?  Or just C 
stubs?

-- 
error compiling committee.c: too many arguments to function