From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=38422 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PxKNf-0005iz-R0
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 09:28:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PxKNe-0003eM-Oz
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 09:28:51 -0500
Received: from mail-iw0-f173.google.com ([209.85.214.173]:33875)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PxKNe-0003eB-KC
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 09:28:50 -0500
Received: by iwl42 with SMTP id 42so665091iwl.4
	for <qemu-devel@nongnu.org>; Wed, 09 Mar 2011 06:28:50 -0800 (PST)
Message-ID: <4D778E9F.5060006@codemonkey.ws>
Date: Wed, 09 Mar 2011 08:28:47 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [RFC][PATCH v7 01/16] Move code related to fd
	handlers into utility functions
References: <1299528642-23631-1-git-send-email-mdroth@linux.vnet.ibm.com>	<1299528642-23631-2-git-send-email-mdroth@linux.vnet.ibm.com>
	<4D778787.1020606@redhat.com>
In-Reply-To: <4D778787.1020606@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, abeekhof@redhat.com, qemu-devel@nongnu.org, Jes.Sorensen@redhat.com, aliguori@linux.vnet.ibm.com, markus_mueller@de.ibm.com

On 03/09/2011 07:58 AM, Paolo Bonzini wrote:
> On 03/07/2011 09:10 PM, Michael Roth wrote:
>> This allows us to implement an i/o loop outside of vl.c that can
>> interact with objects that use qemu_set_fd_handler()
>
> I must say I really dislike the patches 1..3.  It's _really_ getting 
> the QEMU NIH worse.  While it is not really possible to get a new 
> shiny mainloop infrastructure in QEMU like snapping fingers (and I'm 
> not sure the glib mainloop will ever happen there), there is no reason 
> not to adopt glib's infrastructure in virtagent.

I'm 90% in agreement with you but in terms of delivering a Windows guest 
agent, instead of just having an exe, we're now talking about quite a 
few extra DLLs.  It's not a huge problem and probably makes a ton of 
sense if virt-agent ever adopts more sophisticated functionality but I 
wanted to at least raise this point.

Regards,

Anthony Liguori

>   While cooperation between QEMU and virtagent is close, it is IMHO a 
> substantially separate project that can afford starting from a clean 
> slate.
>
> If anybody disagrees, I'd be happy to hear their opinion anyway!
>
> I'm sorry I'm saying this only now and I've been ignoring this series 
> until v7.
>
> Paolo
>
>