From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48050 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxKZ9-0004q3-FV for qemu-devel@nongnu.org; Wed, 09 Mar 2011 09:40:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PxKZ8-0008C6-3Y for qemu-devel@nongnu.org; Wed, 09 Mar 2011 09:40:43 -0500 Received: from e38.co.us.ibm.com ([32.97.110.159]:35278) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PxKZ7-0008B8-RY for qemu-devel@nongnu.org; Wed, 09 Mar 2011 09:40:42 -0500 Received: from d03relay05.boulder.ibm.com (d03relay05.boulder.ibm.com [9.17.195.107]) by e38.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p297Q2CE020825 for ; Wed, 9 Mar 2011 00:26:02 -0700 Received: from d03av05.boulder.ibm.com (d03av05.boulder.ibm.com [9.17.195.85]) by d03relay05.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p29EebSW109278 for ; Wed, 9 Mar 2011 07:40:37 -0700 Received: from d03av05.boulder.ibm.com (loopback [127.0.0.1]) by d03av05.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p29Eeb6E012154 for ; Wed, 9 Mar 2011 07:40:37 -0700 Message-ID: <4D779164.1080608@us.ibm.com> Date: Wed, 09 Mar 2011 08:40:36 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1299528642-23631-1-git-send-email-mdroth@linux.vnet.ibm.com> <1299528642-23631-2-git-send-email-mdroth@linux.vnet.ibm.com> <4D778787.1020606@redhat.com> In-Reply-To: <4D778787.1020606@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC][PATCH v7 01/16] Move code related to fd handlers into utility functions List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, markus_mueller@de.ibm.com, Michael Roth , qemu-devel@nongnu.org, Jes.Sorensen@redhat.com, abeekhof@redhat.com On 03/09/2011 07:58 AM, Paolo Bonzini wrote: > On 03/07/2011 09:10 PM, Michael Roth wrote: >> This allows us to implement an i/o loop outside of vl.c that can >> interact with objects that use qemu_set_fd_handler() > > I must say I really dislike the patches 1..3. It's _really_ getting > the QEMU NIH worse. While it is not really possible to get a new > shiny mainloop infrastructure in QEMU like snapping fingers (and I'm > not sure the glib mainloop will ever happen there While it's not at the immediate top at my MUST DO list, it's still pretty high FWIW. I think the benefits are huge because it means we can refactor things like the VNC server to just interact with glib which means it can become generally useful outside of QEMU. Regards, Anthony Liguori > ), there is no reason not to adopt glib's infrastructure in > virtagent. While cooperation between QEMU and virtagent is close, it > is IMHO a substantially separate project that can afford starting from > a clean slate. > > If anybody disagrees, I'd be happy to hear their opinion anyway! > > I'm sorry I'm saying this only now and I've been ignoring this series > until v7. > > Paolo