From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39459 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PxKqa-0005JN-Pe
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 09:58:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1PxKqZ-0003i4-4v
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 09:58:44 -0500
Received: from mx1.redhat.com ([209.132.183.28]:36607)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1PxKqY-0003hV-Se
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 09:58:43 -0500
Message-ID: <4D7792A1.6060303@redhat.com>
Date: Wed, 09 Mar 2011 15:45:53 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1299528642-23631-1-git-send-email-mdroth@linux.vnet.ibm.com>
	<1299528642-23631-2-git-send-email-mdroth@linux.vnet.ibm.com>
	<4D778787.1020606@redhat.com> <4D779164.1080608@us.ibm.com>
In-Reply-To: <4D779164.1080608@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [RFC][PATCH v7 01/16] Move code related to fd
 handlers into utility functions
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, markus_mueller@de.ibm.com, Michael Roth <mdroth@linux.vnet.ibm.com>, qemu-devel@nongnu.org, Jes.Sorensen@redhat.com, abeekhof@redhat.com

On 03/09/2011 03:40 PM, Anthony Liguori wrote:
>>
>> I must say I really dislike the patches 1..3.  It's _really_ getting
>> the QEMU NIH worse.  While it is not really possible to get a new
>> shiny mainloop infrastructure in QEMU like snapping fingers (and I'm
>> not sure the glib mainloop will ever happen there
>
> While it's not at the immediate top at my MUST DO list, it's still
> pretty high FWIW.  I think the benefits are huge because it means we can
> refactor things like the VNC server to just interact with glib which
> means it can become generally useful outside of QEMU.

I actually agree, but there are a lot of cleanups to do to the code 
before it becomes viable.  I would be surprised to see it before 0.17 
say (maybe a pleasant surprise, but still).

In any case, introducing more dependencies from the tools to core QEMU 
would mean needing wrappers over wrappers over wrappers when QEMU itself 
is refactored.

Perhaps for virtagent something like libnih would be more appropriate? 
Not sure about its Win32 portability though.

Paolo