From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57848 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxL77-0000oJ-F6 for qemu-devel@nongnu.org; Wed, 09 Mar 2011 10:15:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PxL70-0008Vd-Ks for qemu-devel@nongnu.org; Wed, 09 Mar 2011 10:15:49 -0500 Received: from mx1.redhat.com ([209.132.183.28]:17025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PxL70-0008Uu-9G for qemu-devel@nongnu.org; Wed, 09 Mar 2011 10:15:42 -0500 Message-ID: <4D779997.4070300@redhat.com> Date: Wed, 09 Mar 2011 16:15:35 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1299528642-23631-1-git-send-email-mdroth@linux.vnet.ibm.com> <1299528642-23631-2-git-send-email-mdroth@linux.vnet.ibm.com> <4D778787.1020606@redhat.com> <4D778A95.1000808@linux.vnet.ibm.com> <4D7790EB.1050206@redhat.com> <4D77965A.6010106@linux.vnet.ibm.com> In-Reply-To: <4D77965A.6010106@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC][PATCH v7 01/16] Move code related to fd handlers into utility functions List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, abeekhof@redhat.com, qemu-devel@nongnu.org, Jes.Sorensen@redhat.com, aliguori@linux.vnet.ibm.com, markus_mueller@de.ibm.com On 03/09/2011 04:01 PM, Michael Roth wrote: > > These objs: virtagent.o virtagent-server.o virtagent-common.o > virtagent-transport.o virtagent-manager.o > > Are shared by qemu and qemu-va. Okay, that's what I missed. Then I guess it's a pity but there's a good reason. > It seems like a more general one though, that might benefit consumers > other than virtagent. So if this is addressed at some point, > consumers of the common infrastructure proposed here would all > benefit. I doubt, Win32 sockets are almost unusable (QEMU does "select" on them when it has an event from something else) and chardevs use a separate polling mechanism. Paolo