[Qemu-devel] Re: [RFC][PATCH v7 01/16] Move code related to fd handlers into utility functions

[Anthony Liguori <aliguori@us.ibm.com>]

On 03/09/2011 08:45 AM, Paolo Bonzini wrote:
> On 03/09/2011 03:40 PM, Anthony Liguori wrote:
>>>
>>> I must say I really dislike the patches 1..3.  It's _really_ getting
>>> the QEMU NIH worse.  While it is not really possible to get a new
>>> shiny mainloop infrastructure in QEMU like snapping fingers (and I'm
>>> not sure the glib mainloop will ever happen there
>>
>> While it's not at the immediate top at my MUST DO list, it's still
>> pretty high FWIW.  I think the benefits are huge because it means we can
>> refactor things like the VNC server to just interact with glib which
>> means it can become generally useful outside of QEMU.
>
> I actually agree, but there are a lot of cleanups to do to the code 
> before it becomes viable.  I would be surprised to see it before 0.17 
> say (maybe a pleasant surprise, but still).
>
> In any case, introducing more dependencies from the tools to core QEMU 
> would mean needing wrappers over wrappers over wrappers when QEMU 
> itself is refactored.
>
> Perhaps for virtagent something like libnih would be more appropriate? 
> Not sure about its Win32 portability though.

If we do any lib, it should be glib.  I'm just playing devil's advocate 
here in pointing out that adding DLL dependences on Windows is a bit 
painful although probably unavoidable.

Regards,

Anthony Liguori

> Paolo