From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54491 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PxLUP-0004oZ-Hz for qemu-devel@nongnu.org; Wed, 09 Mar 2011 10:39:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PxLUM-0006MI-VD for qemu-devel@nongnu.org; Wed, 09 Mar 2011 10:39:52 -0500 Received: from e2.ny.us.ibm.com ([32.97.182.142]:58025) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PxLUM-0006M1-RQ for qemu-devel@nongnu.org; Wed, 09 Mar 2011 10:39:50 -0500 Received: from d01dlp02.pok.ibm.com (d01dlp02.pok.ibm.com [9.56.224.85]) by e2.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p29FLNGY005899 for ; Wed, 9 Mar 2011 10:21:23 -0500 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by d01dlp02.pok.ibm.com (Postfix) with ESMTP id 49BE66E8036 for ; Wed, 9 Mar 2011 10:39:49 -0500 (EST) Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p29FdmKC435232 for ; Wed, 9 Mar 2011 10:39:49 -0500 Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1]) by d03av06.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p29FiWK1006675 for ; Wed, 9 Mar 2011 08:44:33 -0700 Message-ID: <4D779F41.8070902@us.ibm.com> Date: Wed, 09 Mar 2011 09:39:45 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1299528642-23631-1-git-send-email-mdroth@linux.vnet.ibm.com> <1299528642-23631-2-git-send-email-mdroth@linux.vnet.ibm.com> <4D778787.1020606@redhat.com> <4D779164.1080608@us.ibm.com> <4D7792A1.6060303@redhat.com> In-Reply-To: <4D7792A1.6060303@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [RFC][PATCH v7 01/16] Move code related to fd handlers into utility functions List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: agl@linux.vnet.ibm.com, stefanha@linux.vnet.ibm.com, markus_mueller@de.ibm.com, Michael Roth , qemu-devel@nongnu.org, Jes.Sorensen@redhat.com, abeekhof@redhat.com On 03/09/2011 08:45 AM, Paolo Bonzini wrote: > On 03/09/2011 03:40 PM, Anthony Liguori wrote: >>> >>> I must say I really dislike the patches 1..3. It's _really_ getting >>> the QEMU NIH worse. While it is not really possible to get a new >>> shiny mainloop infrastructure in QEMU like snapping fingers (and I'm >>> not sure the glib mainloop will ever happen there >> >> While it's not at the immediate top at my MUST DO list, it's still >> pretty high FWIW. I think the benefits are huge because it means we can >> refactor things like the VNC server to just interact with glib which >> means it can become generally useful outside of QEMU. > > I actually agree, but there are a lot of cleanups to do to the code > before it becomes viable. I would be surprised to see it before 0.17 > say (maybe a pleasant surprise, but still). > > In any case, introducing more dependencies from the tools to core QEMU > would mean needing wrappers over wrappers over wrappers when QEMU > itself is refactored. > > Perhaps for virtagent something like libnih would be more appropriate? > Not sure about its Win32 portability though. If we do any lib, it should be glib. I'm just playing devil's advocate here in pointing out that adding DLL dependences on Windows is a bit painful although probably unavoidable. Regards, Anthony Liguori > Paolo