From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52908 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PxNLM-0007I6-FB
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 12:38:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PxNLL-0003Hm-6W
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 12:38:40 -0500
Received: from mail-iw0-f173.google.com ([209.85.214.173]:52915)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PxNLL-0003Hi-1B
	for qemu-devel@nongnu.org; Wed, 09 Mar 2011 12:38:39 -0500
Received: by iwl42 with SMTP id 42so871503iwl.4
	for <qemu-devel@nongnu.org>; Wed, 09 Mar 2011 09:38:38 -0800 (PST)
Message-ID: <4D77BB1B.9030704@codemonkey.ws>
Date: Wed, 09 Mar 2011 11:38:35 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] block: Flush image after open
References: <1299687353-20424-1-git-send-email-kwolf@redhat.com>
	<20110309172757.GA2884@lst.de>
In-Reply-To: <20110309172757.GA2884@lst.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Christoph Hellwig <hch@lst.de>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

On 03/09/2011 11:27 AM, Christoph Hellwig wrote:
> On Wed, Mar 09, 2011 at 05:15:53PM +0100, Kevin Wolf wrote:
>> Quoting the bug report:
>>
>>      qemu ensures that guest writes and qemu metadata writes hit the disk
>>      when necessary to prevent data corruption. However, if an image was
>>      in host pagecache prior to starting qemu, for example after running
>>      qemu-img convert, then nothing prevents writes from reaching the
>>      disk out of order, potentially causing corruption.
>>
>> I'm not entirely sure if there is a realistic case where we would get
>> corruption, but it's probably a case of better safe than sorry.
> Except for SCSI with ordered tags (which we don't support) there are not
> ordering guarantees in the storage protocols, and as such the above explanation
> doesn't make any sense at all.

Even if there was, a guest shouldn't be relying on the ordering of a 
write that comes from a non-guest.

I don't understand the failure scenario here.

Regards,

Anthony Liguori

>