From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52027 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PxbtX-0002sR-4z
	for qemu-devel@nongnu.org; Thu, 10 Mar 2011 04:10:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PxbtW-00049B-3Y
	for qemu-devel@nongnu.org; Thu, 10 Mar 2011 04:10:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:34892)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Jes.Sorensen@redhat.com>) id 1PxbtV-00048k-OW
	for qemu-devel@nongnu.org; Thu, 10 Mar 2011 04:10:54 -0500
Message-ID: <4D78958C.3030604@redhat.com>
Date: Thu, 10 Mar 2011 10:10:36 +0100
From: Jes Sorensen <Jes.Sorensen@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] QMP: add snapshot_blkdev_sync command
References: <1299685061-24234-1-git-send-email-Jes.Sorensen@redhat.com>	<4D77A0EA.4060507@codemonkey.ws>
	<4D77A44C.5090904@redhat.com> <4D77B2FD.3050304@codemonkey.ws>
In-Reply-To: <4D77B2FD.3050304@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org, lcapitulino@redhat.com

On 03/09/11 18:03, Anthony Liguori wrote:
> On 03/09/2011 10:01 AM, Kevin Wolf wrote:
>>> I'm not sure blkdev is the right prefix.  Kevin, what are your thoughts
>>> here?  Does 'blkdev' make sense for any command operating on a block
>>> device (that is, a qdev device that happens to have a block drive, not
>>> the same thing as -blockdev that we've discussed in the past).
>> Doesn't this command work on a -blockdev style thing, i.e.
>> BlockDriverState or DriveInfo? I don't think we have any commands that
>> refer to qdev devices that happen to be block devices. You could
>> probably argue that some of them should...
> 
> 'device' is a device name though, right?  Or is it a name associated
> with a BlockDriverState that currently happens to be a qdev name?

It is a device in the sense of what you get from 'info block' in the
human monitor.

> Would I be able to eventually pass a qdev path here?
> 
> If the answer is that this is a bdrv_name, then should we at least use
> blockdev instead of blkdev?

I used blkdev in the human monitor command to reduce the length of the
command name.

Anyway, if you can decide what you want to call the command, I'll rename
it accordingly.

Cheers,
Jes