From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=44638 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Py4bS-0005hS-2C for qemu-devel@nongnu.org; Fri, 11 Mar 2011 10:50:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Py4bN-0007XI-A8 for qemu-devel@nongnu.org; Fri, 11 Mar 2011 10:50:06 -0500 Received: from mail-yx0-f173.google.com ([209.85.213.173]:62844) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Py4bN-0007XD-7M for qemu-devel@nongnu.org; Fri, 11 Mar 2011 10:50:05 -0500 Received: by yxk8 with SMTP id 8so1468413yxk.4 for ; Fri, 11 Mar 2011 07:50:04 -0800 (PST) Message-ID: <4D7A44AB.4030006@codemonkey.ws> Date: Fri, 11 Mar 2011 09:50:03 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] Re: [PATCH v2] Make VNC support optional References: <1299854234-22003-1-git-send-email-Jes.Sorensen@redhat.com> <4D7A3433.2060006@codemonkey.ws> <4D7A37A6.7010300@redhat.com> <4D7A37ED.7020505@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Jes Sorensen , qemu-devel@nongnu.org On 03/11/2011 09:11 AM, Peter Maydell wrote: > On 11 March 2011 14:55, Anthony Liguori wrote: >> On 03/11/2011 08:54 AM, Jes Sorensen wrote: >>> On 03/11/11 15:39, Anthony Liguori wrote: >>>> So what ends up being the default display if VNC and SDL are both >>>> disabled? Have you tested this? >>> Then you cry :) actually you just don't get video output, a bit like if >>> you run with -nographic, except it doesn't try to force taking over >>> stdio. This is intentional btw :) >> Hrm, that doesn't sound very safe to me. Forcing -nographic would be better >> IMHO. > Personally I'd rather -nographic didn't take over stdio either: > it should just disable graphics, and if you want serial on your > stdio you can say "-serial stdio"; it's a bit non-orthogonal > for an option which is about how we handle video output to have > a non-overridable side-effect of redirecting the serial port. > > (Also the "-nographic" running of serial over stdio doesn't let > you kill qemu with ^C, the way "-serial stdio" does, which is > just annoyingly inconsistent...) So if we want to have another mode that has different characteristics, that's fine, but it should be selectable via the command line regardless of how the build is configured. I don't like the idea of a magic mode that is unlocked when other features are disabled because then there's no good way to test such a feature in a full build. Regards, Anthony Liguori