From: Jan Kiszka <jan.kiszka@web.de>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 11/15] kvm: Rework inner loop of kvm_cpu_exec
Date: Sat, 12 Mar 2011 10:16:10 +0100 [thread overview]
Message-ID: <4D7B39DA.80802@web.de> (raw)
In-Reply-To: <20110311213442.GA16222@amt.cnet>
[-- Attachment #1: Type: text/plain, Size: 879 bytes --]
On 2011-03-11 22:34, Marcelo Tosatti wrote:
> On Sat, Mar 05, 2011 at 07:12:50PM +0100, Jan Kiszka wrote:
>>>> @@ -956,7 +956,6 @@ int kvm_cpu_exec(CPUState *env)
>>>> abort();
>>>> }
>>>>
>>>> - ret = 0; /* exit loop */
>>>> switch (run->exit_reason) {
>>>
>>> Better keep ret assignment here so default behaviour is to
>>> exit loop? EXCP_INTERRUPT.
>>
>> There is no real default behavior: in two cases we stay in the loop, in
>> two others we leave, and the rest obtains ret from a return value.
>> Moreover, if a new case misses to set ret, the compiler will complain.
>>
>> Jan
>
> It will not complain because "ret" is used to store return value
> of KVM_RUN.
>
Right, I'll disentangle this duplicate use of 'ret' (writing patches is
likely much better than watching more news this morning...).
Jan
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 259 bytes --]
next prev parent reply other threads:[~2011-03-12 9:16 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 10:19 [Qemu-devel] [PATCH 00/15] [uq/master] Patch queue, part V (the rest) Jan Kiszka
2011-03-04 10:19 ` [Qemu-devel] [PATCH 01/15] Break up user and system cpu_interrupt implementations Jan Kiszka
2011-03-04 10:19 ` [Qemu-devel] [PATCH 02/15] Redirect cpu_interrupt to callback handler Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] [PATCH 03/15] kvm: Install optimized interrupt handlers Jan Kiszka
2011-03-05 15:37 ` [Qemu-devel] " Marcelo Tosatti
2011-03-05 18:11 ` Jan Kiszka
2011-03-06 2:13 ` Marcelo Tosatti
2011-03-07 8:00 ` Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] [PATCH 04/15] kvm: Add in-kernel irqchip awareness to cpu_thread_is_idle Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] [PATCH 05/15] kvm: x86: Do not leave halt if interrupts are disabled Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] [PATCH 06/15] kvm: Mark VCPU state dirty on creation Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] [PATCH 07/15] x86: Properly reset PAT MSR Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] [PATCH 08/15] x86: Save/restore " Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] [PATCH 09/15] kvm: x86: Synchronize PAT MSR with the kernel Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] [PATCH 10/15] kvm: Consider EXIT_DEBUG unknown without CAP_SET_GUEST_DEBUG Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] [PATCH 11/15] kvm: Rework inner loop of kvm_cpu_exec Jan Kiszka
2011-03-05 16:05 ` [Qemu-devel] " Marcelo Tosatti
2011-03-05 18:12 ` Jan Kiszka
2011-03-11 21:34 ` Marcelo Tosatti
2011-03-12 9:16 ` Jan Kiszka [this message]
2011-03-04 10:20 ` [Qemu-devel] [PATCH 12/15] kvm: Align kvm_arch_handle_exit to kvm_cpu_exec changes Jan Kiszka
2011-03-11 6:50 ` [Qemu-devel] " Alexander Graf
2011-03-11 7:13 ` Jan Kiszka
2011-03-11 7:26 ` Alexander Graf
2011-03-11 7:33 ` Jan Kiszka
2011-03-11 7:38 ` Alexander Graf
2011-03-11 7:35 ` Alexander Graf
2011-03-04 10:20 ` [Qemu-devel] [PATCH 13/15] kvm: x86: Reorder functions in kvm.c Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] [PATCH 14/15] kvm: x86: Push kvm_arch_debug to kvm_arch_handle_exit Jan Kiszka
2011-03-04 10:20 ` [Qemu-devel] [PATCH 15/15] Expose thread_id in info cpus Jan Kiszka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7B39DA.80802@web.de \
--to=jan.kiszka@web.de \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).