From: Anthony Liguori <anthony@codemonkey.ws>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH 0/5] allow arbitrary scaling of timers
Date: Sat, 12 Mar 2011 17:33:10 -0600 [thread overview]
Message-ID: <4D7C02B6.3000503@codemonkey.ws> (raw)
In-Reply-To: <1299949460-4387-1-git-send-email-pbonzini@redhat.com>
On 03/12/2011 11:04 AM, Paolo Bonzini wrote:
> Right now, rt_clock timers are limited to millisecond resolutions;
> other clocks are limited to nanoseconds. This patch series removes
> the limitation.
>
> In order to ease transition, new functions are provided with
> explicit resolution (milli/nanosecond). The old qemu_get_clock
> is removed. The old qemu_new_timer is grown a new argument to
> specify the resolution.
>
> Most of the patch series (patches 2/3) is mechanical (sed).
Really nice series.
The whole thing Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
Did you really mean to RFC this? I don't think there's any sort of
problem applying this as it's mostly mechanical.
Regards,
Anthony Liguori
> Paolo Bonzini (5):
> add more helper functions with explicit milli/nanosecond resolution
> change all rt_clock references to use millisecond resolution
> accessors
> change all other clock references to use nanosecond resolution
> accessors
> add a generic scaling mechanism for timers
> remove qemu_get_clock
>
> audio/audio.c | 4 +-
> audio/noaudio.c | 4 +-
> audio/spiceaudio.c | 4 +-
> audio/wavaudio.c | 2 +-
> buffered_file.c | 6 ++--
> console.c | 4 +-
> hw/acpi_piix4.c | 8 +++---
> hw/adlib.c | 2 +-
> hw/apic.c | 8 +++---
> hw/arm_sysctl.c | 2 +-
> hw/armv7m_nvic.c | 8 +++---
> hw/baum.c | 4 +-
> hw/bt-hci-csr.c | 4 +-
> hw/bt-hci.c | 12 +++++-----
> hw/cuda.c | 24 ++++++++++----------
> hw/dp8393x.c | 6 ++--
> hw/etraxfs_timer.c | 2 +-
> hw/fdc.c | 4 +-
> hw/hpet.c | 14 +++++-----
> hw/i8254.c | 12 +++++-----
> hw/i8259.c | 4 +-
> hw/ide/core.c | 4 +-
> hw/intel-hda.c | 2 +-
> hw/lan9118.c | 4 +-
> hw/lm832x.c | 6 ++--
> hw/m48t59.c | 6 ++--
> hw/mc146818rtc.c | 16 ++++++------
> hw/mips_timer.c | 10 ++++----
> hw/mpcore.c | 6 ++--
> hw/omap1.c | 30 ++++++++++++------------
> hw/omap_gptimer.c | 14 +++++-----
> hw/omap_synctimer.c | 2 +-
> hw/pcnet.c | 6 ++--
> hw/pcspk.c | 2 +-
> hw/pflash_cfi01.c | 2 +-
> hw/pflash_cfi02.c | 6 ++--
> hw/pl031.c | 8 +++---
> hw/ppc.c | 52 +++++++++++++++++++++---------------------
> hw/ppc405_uc.c | 6 ++--
> hw/ppc_prep.c | 2 +-
> hw/ptimer.c | 14 +++++-----
> hw/pxa2xx.c | 30 ++++++++++++------------
> hw/pxa2xx_timer.c | 28 +++++++++++-----------
> hw/rc4030.c | 4 +-
> hw/rtl8139.c | 22 +++++++++---------
> hw/sb16.c | 4 +-
> hw/serial.c | 20 ++++++++--------
> hw/soc_dma.c | 4 +-
> hw/spitz.c | 6 ++--
> hw/stellaris.c | 6 ++--
> hw/sun4u.c | 12 +++++-----
> hw/syborg_rtc.c | 2 +-
> hw/tsc2005.c | 4 +-
> hw/tsc210x.c | 20 ++++++++--------
> hw/tusb6010.c | 8 +++---
> hw/twl92230.c | 8 +++---
> hw/usb-hid.c | 6 ++--
> hw/usb-musb.c | 4 +-
> hw/usb-ohci.c | 8 +++---
> hw/usb-uhci.c | 6 ++--
> hw/vga.c | 2 +-
> hw/virtio-net.c | 6 ++--
> hw/vt82c686.c | 8 +++---
> hw/wdt_i6300esb.c | 4 +-
> hw/wdt_ib700.c | 4 +-
> hw/xen_domainbuild.c | 6 ++--
> monitor.c | 4 +-
> net/dump.c | 2 +-
> qemu-char.c | 8 +++---
> qemu-timer.c | 60 +++++++++++++++++++++----------------------------
> qemu-timer.h | 25 +++++++++++++++++++-
> savevm.c | 6 ++--
> slirp/slirp.c | 2 +-
> target-ppc/kvm.c | 4 +-
> target-ppc/kvm_ppc.c | 6 ++--
> ui/spice-core.c | 4 +-
> ui/vnc.c | 10 ++++----
> usb-linux.c | 4 +-
> vl.c | 12 +++++-----
> 79 files changed, 364 insertions(+), 351 deletions(-)
>
next prev parent reply other threads:[~2011-03-12 23:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 17:04 [Qemu-devel] [RFC PATCH 0/5] allow arbitrary scaling of timers Paolo Bonzini
2011-03-12 17:04 ` [Qemu-devel] [RFC PATCH 1/5] add more helper functions with explicit milli/nanosecond resolution Paolo Bonzini
2011-03-12 17:04 ` [Qemu-devel] [RFC PATCH 2/5] change all rt_clock references to use millisecond resolution accessors Paolo Bonzini
2011-03-12 17:04 ` [Qemu-devel] [RFC PATCH 3/5] change all other clock references to use nanosecond " Paolo Bonzini
2011-03-12 17:04 ` [Qemu-devel] [RFC PATCH 4/5] add a generic scaling mechanism for timers Paolo Bonzini
2011-03-12 17:04 ` [Qemu-devel] [RFC PATCH 5/5] remove qemu_get_clock Paolo Bonzini
2011-03-12 23:33 ` Anthony Liguori [this message]
2011-03-14 7:14 ` [Qemu-devel] [RFC PATCH 0/5] allow arbitrary scaling of timers Paolo Bonzini
2011-03-21 13:35 ` [Qemu-devel] [PULL] " Paolo Bonzini
2011-03-21 20:44 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D7C02B6.3000503@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).