From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=42114 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pz76O-0006Yz-O5 for qemu-devel@nongnu.org; Mon, 14 Mar 2011 08:42:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pz76N-0006ga-5S for qemu-devel@nongnu.org; Mon, 14 Mar 2011 08:42:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43636) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pz76M-0006gT-S7 for qemu-devel@nongnu.org; Mon, 14 Mar 2011 08:42:23 -0400 Message-ID: <4D7E0D16.8070405@redhat.com> Date: Mon, 14 Mar 2011 13:41:58 +0100 From: Jes Sorensen MIME-Version: 1.0 References: <1300105726-25937-1-git-send-email-Jes.Sorensen@redhat.com> <1300105726-25937-2-git-send-email-Jes.Sorensen@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 1/5] Introduce -display argument List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org On 03/14/11 13:40, Peter Maydell wrote: > On 14 March 2011 12:28, wrote: >> This patch introduces a -display argument which consolidates the >> setting of the display mode. Valid options are: >> sdl/curses/default/nographic > > I wasn't expecting to see "nographic" as an option here -- my > preference would be to retain the existing '-nographic' switch > for backwards-compatibility, but '-display foo' should only > affect the video type. (ie the equivalent of '-nographic' ought > to be a set of options including '-display none', '-serial mon:stdio' > and so on, not a single '-display:nographic'). It would be easy to remove it from the -display option, but I think it is fair to keep it in. I was pretty much trying to cover every DT_foo option we have. If nographic is going away as a display option, we should make it in the code that it is for legacy support only. Cheers, Jes