From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=56030 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pz7xg-00036X-Vi
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 09:37:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Pz7xe-0001Gh-MB
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 09:37:27 -0400
Received: from mail-yw0-f45.google.com ([209.85.213.45]:53223)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Pz7xe-0001Gb-Dk
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 09:37:26 -0400
Received: by ywl41 with SMTP id 41so2533540ywl.4
	for <qemu-devel@nongnu.org>; Mon, 14 Mar 2011 06:37:25 -0700 (PDT)
Message-ID: <4D7E1A13.7090202@codemonkey.ws>
Date: Mon, 14 Mar 2011 08:37:23 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1300105726-25937-1-git-send-email-Jes.Sorensen@redhat.com>
	<1300105726-25937-2-git-send-email-Jes.Sorensen@redhat.com>
In-Reply-To: <1300105726-25937-2-git-send-email-Jes.Sorensen@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 1/5] Introduce -display argument
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: jan.kiszka@siemens.com, qemu-devel@nongnu.org, peter.maydell@linaro.org

On 03/14/2011 07:28 AM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> This patch introduces a -display argument which consolidates the
> setting of the display mode. Valid options are:
> sdl/curses/default/nographic
>
> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>

I'd suggest using 'serial' instead of 'nographic' as that makes it more 
obvious to the user that they need to configure a serial session.

I would drop 'default' for no other reason than we don't really expose 
default as a choice anywhere else and I'm struggling to justify it to 
myself.

I think we also need to leave room to make -display take per-display 
specific parameters via QemuOpts.  That said, converting -vnc to 
QemuOpts is hard so what I'd suggest doing is just cheating for the 
moment.  Document the option to take per-display args after the main 
display, and then do something like:

if (strstarts(optarg, "vnc,", &p)) {
      vnc_display_init(p);
}

We have a bunch of little stupid SDL options like -sdl-no-frame and it 
would be good to eventually be able to express that as -display 
sdl,frame=off

Regards,

Anthony Liguori