From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45123 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pz8W3-0007wa-Lo
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 10:13:01 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Pz8W1-0000u8-HU
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 10:12:58 -0400
Received: from mail-iw0-f173.google.com ([209.85.214.173]:57070)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Pz8W1-0000tl-AG
	for qemu-devel@nongnu.org; Mon, 14 Mar 2011 10:12:57 -0400
Received: by iwl42 with SMTP id 42so5811181iwl.4
	for <qemu-devel@nongnu.org>; Mon, 14 Mar 2011 07:12:56 -0700 (PDT)
Message-ID: <4D7E2265.1020306@codemonkey.ws>
Date: Mon, 14 Mar 2011 09:12:53 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus
References: <1298460024-23591-1-git-send-email-alevy@redhat.com>	<1298460024-23591-2-git-send-email-alevy@redhat.com>	<4D7E1E33.1070801@redhat.com>
	<20110314140749.GD23458@redhat.com>
In-Reply-To: <20110314140749.GD23458@redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: Jes Sorensen <Jes.Sorensen@redhat.com>, Alon Levy <alevy@redhat.com>, qemu-devel@nongnu.org

On 03/14/2011 09:07 AM, Daniel P. Berrange wrote:
> On Mon, Mar 14, 2011 at 02:54:59PM +0100, Jes Sorensen wrote:
>> On 02/23/11 12:20, Alon Levy wrote:
>>> diff --git a/configure b/configure
>>> index 791b71d..147aab3 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -174,6 +174,7 @@ trace_backend="nop"
>>>   trace_file="trace"
>>>   spice=""
>>>   rbd=""
>>> +smartcard="yes"
>> IMHO smartcard support shouldn't be enabled per default. The userbase is
>> limited.
> Deciding based on importance/size of userbase is rather subjective.
> IMHO all features should be enabled by default, but if they depend
> on a 3rd party library that isn't installed on the build host, they
> should automatically disable themselves. eg

Yes, and this is the policy we've taken pretty consistently in QEMU.

Features that aren't enabled by default are subject to bit-rot.

Regards,

Anthony Liguori

>   * [the default]       - on, if external library is present, off otherwise
>   * --enable-<feature>   - always on, raise error if external library is missing
>   * --disable-<feature>  - always off,
>
> Regards,
> Daniel